database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-06 19:59:18 +03:00
Code

Revert "When WalSndCaughtUp, sleep only in WalSndWaitForWal()."

Browse Source 
This reverts commit 421685812290406daea58b78dfab0346eb683bbb.  It caused
idle physical walsenders to busy-wait, as reported by Fujii Masao.

Discussion: https://postgr.es/m/20200417054146.GA1061007@rfd.leadboat.com
This commit is contained in:
Noah Misch 2020-04-25 10:17:26 -07:00
parent d9a4cce29d
commit 72a3dc321d
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/backend/replication/walsender.c
View File

@ -1428,10 +1428,8 @@ WalSndWaitForWal(XLogRecPtr loc)
/* /*
* We only send regular messages to the client for full decoded * We only send regular messages to the client for full decoded
* transactions, but a synchronous replication and walsender shutdown * transactions, but a synchronous replication and walsender shutdown
* possibly are waiting for a later location. So, before sleeping, we * possibly are waiting for a later location. So we send pings
* send a ping containing the flush location. If the receiver is * containing the flush location every now and then.
* otherwise idle, this keepalive will trigger a reply. Processing the
* reply will update these MyWalSnd locations.
*/ */
if (MyWalSnd->flush < sentPtr && if (MyWalSnd->flush < sentPtr &&
MyWalSnd->write < sentPtr && MyWalSnd->write < sentPtr &&
@ -2316,16 +2314,20 @@ WalSndLoop(WalSndSendDataCallback send_data)
WalSndKeepaliveIfNecessary(); WalSndKeepaliveIfNecessary();
/* /*
* Block if we have unsent data. Let WalSndWaitForWal() handle any * We don't block if not caught up, unless there is unsent data
* other blocking; idle receivers need its additional actions. * pending in which case we'd better block until the socket is
* write-ready. This test is only needed for the case where the
* send_data callback handled a subset of the available data but then
* pq_flush_if_writable flushed it all --- we should immediately try
* to send more.
*/ */
if (pq_is_send_pending()) if ((WalSndCaughtUp && !streamingDoneSending) || pq_is_send_pending())
{ {
long sleeptime; long sleeptime;
int wakeEvents; int wakeEvents;
wakeEvents = WL_LATCH_SET | WL_EXIT_ON_PM_DEATH | WL_TIMEOUT | wakeEvents = WL_LATCH_SET | WL_EXIT_ON_PM_DEATH | WL_TIMEOUT |
WL_SOCKET_READABLE | WL_SOCKET_WRITEABLE; WL_SOCKET_READABLE;
/* /*
* Use fresh timestamp, not last_processing, to reduce the chance * Use fresh timestamp, not last_processing, to reduce the chance
@ -2333,6 +2335,9 @@ WalSndLoop(WalSndSendDataCallback send_data)
*/ */
sleeptime = WalSndComputeSleeptime(GetCurrentTimestamp()); sleeptime = WalSndComputeSleeptime(GetCurrentTimestamp());
if (pq_is_send_pending())
wakeEvents |= WL_SOCKET_WRITEABLE;
/* Sleep until something happens or we time out */ /* Sleep until something happens or we time out */
(void) WaitLatchOrSocket(MyLatch, wakeEvents, (void) WaitLatchOrSocket(MyLatch, wakeEvents,
MyProcPort->sock, sleeptime, MyProcPort->sock, sleeptime,