mirror of
https://github.com/postgres/postgres.git
synced 2025-11-25 12:03:53 +03:00
Revert commit 66c0185a3 and follow-on patches.
This reverts66c0185a3(Allow planner to use Merge Append to efficiently implement UNION) as well as the follow-on commitsd5d2205c8,3b1a7eb28,7487044d6. In addition to those,07746a8efhad to be removed then re-applied in a different place, because66c0185a3moved the relevant code. The reason for this last-minute thrashing is that depesz found a case in which the patched code creates a completely wrong plan that silently gives incorrect query results. It's unclear what the cause is or how many cases are affected, but with beta1 wrap staring us in the face, there's no time for closer investigation. After we figure that out, we can decide whether to un-revert this for beta2 or hold it for v18. Discussion: https://postgr.es/m/Zktzf926vslR35Fv@depesz.com (also some private discussion among pgsql-release)
This commit is contained in:
@@ -173,10 +173,6 @@ extern void add_child_join_rel_equivalences(PlannerInfo *root,
|
||||
AppendRelInfo **appinfos,
|
||||
RelOptInfo *parent_joinrel,
|
||||
RelOptInfo *child_joinrel);
|
||||
extern void add_setop_child_rel_equivalences(PlannerInfo *root,
|
||||
RelOptInfo *child_rel,
|
||||
List *child_tlist,
|
||||
List *setop_pathkeys);
|
||||
extern List *generate_implied_equalities_for_column(PlannerInfo *root,
|
||||
RelOptInfo *rel,
|
||||
ec_matches_callback_type callback,
|
||||
|
||||
@@ -44,8 +44,7 @@ extern PlannedStmt *standard_planner(Query *parse, const char *query_string,
|
||||
|
||||
extern PlannerInfo *subquery_planner(PlannerGlobal *glob, Query *parse,
|
||||
PlannerInfo *parent_root,
|
||||
bool hasRecursion, double tuple_fraction,
|
||||
SetOperationStmt *setops);
|
||||
bool hasRecursion, double tuple_fraction);
|
||||
|
||||
extern RowMarkType select_rowmark_type(RangeTblEntry *rte,
|
||||
LockClauseStrength strength);
|
||||
|
||||
@@ -53,6 +53,6 @@ extern void preprocess_aggrefs(PlannerInfo *root, Node *clause);
|
||||
* prototypes for prepunion.c
|
||||
*/
|
||||
extern RelOptInfo *plan_set_operations(PlannerInfo *root);
|
||||
extern bool set_operation_ordered_results_useful(SetOperationStmt *setop);
|
||||
|
||||
|
||||
#endif /* PREP_H */
|
||||
|
||||
Reference in New Issue
Block a user