database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-29 22:49:41 +03:00
Code Activity

Remove useless pstrdup() calls.

Browse Source 
The result of PLyUnicode_AsString is already palloc'd,
so pstrdup'ing it is just a waste of time and memory.
More importantly it might confuse people about whether
that's necessary.  Doesn't seem important enough to
back-patch, but we should fix it.  Spotted by Coverity.
This commit is contained in:
Tom Lane
2025-10-22 16:22:52 -04:00
parent bc310c6ff3
commit 716c451128
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/pl/plpython/plpy_elog.c
View File

@@ -571,7 +571,7 @@ get_string_attr(PyObject *obj, char *attrname, char **str)
val = PyObject_GetAttrString(obj, attrname); val = PyObject_GetAttrString(obj, attrname);
if (val != NULL && val != Py_None) if (val != NULL && val != Py_None)
{ {
*str = pstrdup(PLyUnicode_AsString(val)); *str = PLyUnicode_AsString(val);
} }
Py_XDECREF(val); Py_XDECREF(val);
} }

4
src/pl/plpython/plpy_plpymodule.c
View File

@@ -369,7 +369,7 @@ PLy_quote_ident(PyObject *self, PyObject *args)
return ret; return ret;
} }
/* enforce cast of object to string */ /* enforce cast of object to string (returns a palloc'd string or NULL) */
static char * static char *
object_to_string(PyObject *obj) object_to_string(PyObject *obj)
{ {
@@ -381,7 +381,7 @@ object_to_string(PyObject *obj)
{ {
char *str; char *str;
str = pstrdup(PLyUnicode_AsString(so)); str = PLyUnicode_AsString(so);
Py_DECREF(so); Py_DECREF(so);
return str; return str;