database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Remove support for upgrading extensions from "unpackaged" state.

Browse Source 
Andres Freund pointed out that allowing non-superusers to run
"CREATE EXTENSION ... FROM unpackaged" has security risks, since
the unpackaged-to-1.0 scripts don't try to verify that the existing
objects they're modifying are what they expect.  Just attaching such
objects to an extension doesn't seem too dangerous, but some of them
do more than that.

We could have resolved this, perhaps, by still requiring superuser
privilege to use the FROM option.  However, it's fair to ask just what
we're accomplishing by continuing to lug the unpackaged-to-1.0 scripts
forward.  None of them have received any real testing since 9.1 days,
so they may not even work anymore (even assuming that one could still
load the previous "loose" object definitions into a v13 database).
And an installation that's trying to go from pre-9.1 to v13 or later
in one jump is going to have worse compatibility problems than whether
there's a trivial way to convert their contrib modules into extension
style.

Hence, let's just drop both those scripts and the core-code support
for "CREATE EXTENSION ... FROM".

Discussion: https://postgr.es/m/20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de
This commit is contained in:
Tom Lane
2020-02-19 16:59:14 -05:00
parent 2f9c46a32b
commit 70a7732007
84 changed files with 55 additions and 2428 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/earthdistance/Makefile
View File

@ -3,8 +3,7 @@
MODULES = earthdistance
EXTENSION = earthdistance
DATA = earthdistance--1.1.sql earthdistance--1.0--1.1.sql \
earthdistance--unpackaged--1.0.sql
DATA = earthdistance--1.1.sql earthdistance--1.0--1.1.sql
PGFILEDESC = "earthdistance - calculate distances on the surface of the Earth"
REGRESS = earthdistance

16
contrib/earthdistance/earthdistance--unpackaged--1.0.sql
View File

@ -1,16 +0,0 @@
/* contrib/earthdistance/earthdistance--unpackaged--1.0.sql */
-- complain if script is sourced in psql, rather than via CREATE EXTENSION
\echo Use "CREATE EXTENSION earthdistance FROM unpackaged" to load this file. \quit
ALTER EXTENSION earthdistance ADD function earth();
ALTER EXTENSION earthdistance ADD type earth;
ALTER EXTENSION earthdistance ADD function sec_to_gc(double precision);
ALTER EXTENSION earthdistance ADD function gc_to_sec(double precision);
ALTER EXTENSION earthdistance ADD function ll_to_earth(double precision,double precision);
ALTER EXTENSION earthdistance ADD function latitude(earth);
ALTER EXTENSION earthdistance ADD function longitude(earth);
ALTER EXTENSION earthdistance ADD function earth_distance(earth,earth);
ALTER EXTENSION earthdistance ADD function earth_box(earth,double precision);
ALTER EXTENSION earthdistance ADD function geo_distance(point,point);
ALTER EXTENSION earthdistance ADD operator <@>(point,point);