database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-31 22:04:40 +03:00
Code Activity

Remove support for upgrading extensions from "unpackaged" state.

Browse Source 
Andres Freund pointed out that allowing non-superusers to run
"CREATE EXTENSION ... FROM unpackaged" has security risks, since
the unpackaged-to-1.0 scripts don't try to verify that the existing
objects they're modifying are what they expect.  Just attaching such
objects to an extension doesn't seem too dangerous, but some of them
do more than that.

We could have resolved this, perhaps, by still requiring superuser
privilege to use the FROM option.  However, it's fair to ask just what
we're accomplishing by continuing to lug the unpackaged-to-1.0 scripts
forward.  None of them have received any real testing since 9.1 days,
so they may not even work anymore (even assuming that one could still
load the previous "loose" object definitions into a v13 database).
And an installation that's trying to go from pre-9.1 to v13 or later
in one jump is going to have worse compatibility problems than whether
there's a trivial way to convert their contrib modules into extension
style.

Hence, let's just drop both those scripts and the core-code support
for "CREATE EXTENSION ... FROM".

Discussion: https://postgr.es/m/20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de
This commit is contained in:
Tom Lane
2020-02-19 16:59:14 -05:00
parent 2f9c46a32b
commit 70a7732007
84 changed files with 55 additions and 2428 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/dblink/Makefile
View File

@ -8,8 +8,7 @@ PG_CPPFLAGS = -I$(libpq_srcdir)
SHLIB_LINK_INTERNAL = $(libpq)
EXTENSION = dblink
DATA = dblink--1.2.sql dblink--1.1--1.2.sql dblink--1.0--1.1.sql \
dblink--unpackaged--1.0.sql
DATA = dblink--1.2.sql dblink--1.1--1.2.sql dblink--1.0--1.1.sql
PGFILEDESC = "dblink - connect to other PostgreSQL databases"
REGRESS = paths dblink

46
contrib/dblink/dblink--unpackaged--1.0.sql
View File

@ -1,46 +0,0 @@
/* contrib/dblink/dblink--unpackaged--1.0.sql */
-- complain if script is sourced in psql, rather than via CREATE EXTENSION
\echo Use "CREATE EXTENSION dblink FROM unpackaged" to load this file. \quit
ALTER EXTENSION dblink ADD function dblink_connect(text);
ALTER EXTENSION dblink ADD function dblink_connect(text,text);
ALTER EXTENSION dblink ADD function dblink_connect_u(text);
ALTER EXTENSION dblink ADD function dblink_connect_u(text,text);
ALTER EXTENSION dblink ADD function dblink_disconnect();
ALTER EXTENSION dblink ADD function dblink_disconnect(text);
ALTER EXTENSION dblink ADD function dblink_open(text,text);
ALTER EXTENSION dblink ADD function dblink_open(text,text,boolean);
ALTER EXTENSION dblink ADD function dblink_open(text,text,text);
ALTER EXTENSION dblink ADD function dblink_open(text,text,text,boolean);
ALTER EXTENSION dblink ADD function dblink_fetch(text,integer);
ALTER EXTENSION dblink ADD function dblink_fetch(text,integer,boolean);
ALTER EXTENSION dblink ADD function dblink_fetch(text,text,integer);
ALTER EXTENSION dblink ADD function dblink_fetch(text,text,integer,boolean);
ALTER EXTENSION dblink ADD function dblink_close(text);
ALTER EXTENSION dblink ADD function dblink_close(text,boolean);
ALTER EXTENSION dblink ADD function dblink_close(text,text);
ALTER EXTENSION dblink ADD function dblink_close(text,text,boolean);
ALTER EXTENSION dblink ADD function dblink(text,text);
ALTER EXTENSION dblink ADD function dblink(text,text,boolean);
ALTER EXTENSION dblink ADD function dblink(text);
ALTER EXTENSION dblink ADD function dblink(text,boolean);
ALTER EXTENSION dblink ADD function dblink_exec(text,text);
ALTER EXTENSION dblink ADD function dblink_exec(text,text,boolean);
ALTER EXTENSION dblink ADD function dblink_exec(text);
ALTER EXTENSION dblink ADD function dblink_exec(text,boolean);
ALTER EXTENSION dblink ADD type dblink_pkey_results;
ALTER EXTENSION dblink ADD function dblink_get_pkey(text);
ALTER EXTENSION dblink ADD function dblink_build_sql_insert(text,int2vector,integer,text[],text[]);
ALTER EXTENSION dblink ADD function dblink_build_sql_delete(text,int2vector,integer,text[]);
ALTER EXTENSION dblink ADD function dblink_build_sql_update(text,int2vector,integer,text[],text[]);
ALTER EXTENSION dblink ADD function dblink_current_query();
ALTER EXTENSION dblink ADD function dblink_send_query(text,text);
ALTER EXTENSION dblink ADD function dblink_is_busy(text);
ALTER EXTENSION dblink ADD function dblink_get_result(text);
ALTER EXTENSION dblink ADD function dblink_get_result(text,boolean);
ALTER EXTENSION dblink ADD function dblink_get_connections();
ALTER EXTENSION dblink ADD function dblink_cancel_query(text);
ALTER EXTENSION dblink ADD function dblink_error_message(text);
ALTER EXTENSION dblink ADD function dblink_get_notify();
ALTER EXTENSION dblink ADD function dblink_get_notify(text);