database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Remove support for upgrading extensions from "unpackaged" state.

Browse Source 
Andres Freund pointed out that allowing non-superusers to run
"CREATE EXTENSION ... FROM unpackaged" has security risks, since
the unpackaged-to-1.0 scripts don't try to verify that the existing
objects they're modifying are what they expect.  Just attaching such
objects to an extension doesn't seem too dangerous, but some of them
do more than that.

We could have resolved this, perhaps, by still requiring superuser
privilege to use the FROM option.  However, it's fair to ask just what
we're accomplishing by continuing to lug the unpackaged-to-1.0 scripts
forward.  None of them have received any real testing since 9.1 days,
so they may not even work anymore (even assuming that one could still
load the previous "loose" object definitions into a v13 database).
And an installation that's trying to go from pre-9.1 to v13 or later
in one jump is going to have worse compatibility problems than whether
there's a trivial way to convert their contrib modules into extension
style.

Hence, let's just drop both those scripts and the core-code support
for "CREATE EXTENSION ... FROM".

Discussion: https://postgr.es/m/20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de
This commit is contained in:
Tom Lane
2020-02-19 16:59:14 -05:00
parent 2f9c46a32b
commit 70a7732007
84 changed files with 55 additions and 2428 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/cube/Makefile
View File

@ -8,8 +8,7 @@ OBJS = \
EXTENSION = cube
DATA = cube--1.2.sql cube--1.2--1.3.sql cube--1.3--1.4.sql \
cube--1.1--1.2.sql cube--1.0--1.1.sql \
cube--unpackaged--1.0.sql
cube--1.1--1.2.sql cube--1.0--1.1.sql
PGFILEDESC = "cube - multidimensional cube data type"
HEADERS = cubedata.h

56
contrib/cube/cube--unpackaged--1.0.sql
View File

@ -1,56 +0,0 @@
/* contrib/cube/cube--unpackaged--1.0.sql */
-- complain if script is sourced in psql, rather than via CREATE EXTENSION
\echo Use "CREATE EXTENSION cube FROM unpackaged" to load this file. \quit
ALTER EXTENSION cube ADD type cube;
ALTER EXTENSION cube ADD function cube_in(cstring);
ALTER EXTENSION cube ADD function cube(double precision[],double precision[]);
ALTER EXTENSION cube ADD function cube(double precision[]);
ALTER EXTENSION cube ADD function cube_out(cube);
ALTER EXTENSION cube ADD function cube_eq(cube,cube);
ALTER EXTENSION cube ADD function cube_ne(cube,cube);
ALTER EXTENSION cube ADD function cube_lt(cube,cube);
ALTER EXTENSION cube ADD function cube_gt(cube,cube);
ALTER EXTENSION cube ADD function cube_le(cube,cube);
ALTER EXTENSION cube ADD function cube_ge(cube,cube);
ALTER EXTENSION cube ADD function cube_cmp(cube,cube);
ALTER EXTENSION cube ADD function cube_contains(cube,cube);
ALTER EXTENSION cube ADD function cube_contained(cube,cube);
ALTER EXTENSION cube ADD function cube_overlap(cube,cube);
ALTER EXTENSION cube ADD function cube_union(cube,cube);
ALTER EXTENSION cube ADD function cube_inter(cube,cube);
ALTER EXTENSION cube ADD function cube_size(cube);
ALTER EXTENSION cube ADD function cube_subset(cube,integer[]);
ALTER EXTENSION cube ADD function cube_distance(cube,cube);
ALTER EXTENSION cube ADD function cube_dim(cube);
ALTER EXTENSION cube ADD function cube_ll_coord(cube,integer);
ALTER EXTENSION cube ADD function cube_ur_coord(cube,integer);
ALTER EXTENSION cube ADD function cube(double precision);
ALTER EXTENSION cube ADD function cube(double precision,double precision);
ALTER EXTENSION cube ADD function cube(cube,double precision);
ALTER EXTENSION cube ADD function cube(cube,double precision,double precision);
ALTER EXTENSION cube ADD function cube_is_point(cube);
ALTER EXTENSION cube ADD function cube_enlarge(cube,double precision,integer);
ALTER EXTENSION cube ADD operator >(cube,cube);
ALTER EXTENSION cube ADD operator >=(cube,cube);
ALTER EXTENSION cube ADD operator <(cube,cube);
ALTER EXTENSION cube ADD operator <=(cube,cube);
ALTER EXTENSION cube ADD operator &&(cube,cube);
ALTER EXTENSION cube ADD operator <>(cube,cube);
ALTER EXTENSION cube ADD operator =(cube,cube);
ALTER EXTENSION cube ADD operator <@(cube,cube);
ALTER EXTENSION cube ADD operator @>(cube,cube);
ALTER EXTENSION cube ADD operator ~(cube,cube);
ALTER EXTENSION cube ADD operator @(cube,cube);
ALTER EXTENSION cube ADD function g_cube_consistent(internal,cube,integer,oid,internal);
ALTER EXTENSION cube ADD function g_cube_compress(internal);
ALTER EXTENSION cube ADD function g_cube_decompress(internal);
ALTER EXTENSION cube ADD function g_cube_penalty(internal,internal,internal);
ALTER EXTENSION cube ADD function g_cube_picksplit(internal,internal);
ALTER EXTENSION cube ADD function g_cube_union(internal,internal);
ALTER EXTENSION cube ADD function g_cube_same(cube,cube,internal);
ALTER EXTENSION cube ADD operator family cube_ops using btree;
ALTER EXTENSION cube ADD operator class cube_ops using btree;
ALTER EXTENSION cube ADD operator family gist_cube_ops using gist;
ALTER EXTENSION cube ADD operator class gist_cube_ops using gist;