database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-02 04:21:28 +03:00
Code Activity

Remove error message hints mentioning configure options

Browse Source 
These are usually not useful since users will use packaged
distributions and won't be interested in rebuilding their installation
from source.  Also, we have only used these kinds of hints for some
features and in some places, not consistently throughout.

Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/2552aed7-d0e9-280a-54aa-2dc7073f371d%40enterprisedb.com
This commit is contained in:
Peter Eisentraut
2022-04-08 07:41:09 +02:00
parent b3abca6810
commit 708007dced
8 changed files with 4 additions and 207 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/access/common/toast_compression.c
View File

@@ -30,8 +30,7 @@ int default_toast_compression = TOAST_PGLZ_COMPRESSION;
ereport(ERROR, \
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED), \
errmsg("compression method lz4 not supported"), \
errdetail("This functionality requires the server to be built with lz4 support."), \
errhint("You need to rebuild PostgreSQL using %s.", "--with-lz4")))
errdetail("This functionality requires the server to be built with lz4 support.")))
/*
* Compress a varlena using PGLZ.

2
src/backend/libpq/hba.c
View File

@@ -1010,7 +1010,6 @@ parse_hba_line(TokenizedAuthLine *tok_line, int elevel)
ereport(elevel,
(errcode(ERRCODE_CONFIG_FILE_ERROR),
errmsg("hostssl record cannot match because SSL is not supported by this build"),
errhint("Compile with --with-ssl to use SSL connections."),
errcontext("line %d of configuration file \"%s\"",
line_num, HbaFileName)));
*err_msg = "hostssl record cannot match because SSL is not supported by this build";
@@ -1023,7 +1022,6 @@ parse_hba_line(TokenizedAuthLine *tok_line, int elevel)
ereport(elevel,
(errcode(ERRCODE_CONFIG_FILE_ERROR),
errmsg("hostgssenc record cannot match because GSSAPI is not supported by this build"),
errhint("Compile with --with-gssapi to use GSSAPI connections."),
errcontext("line %d of configuration file \"%s\"",
line_num, HbaFileName)));
*err_msg = "hostgssenc record cannot match because GSSAPI is not supported by this build";

6
src/backend/utils/adt/pg_locale.c
View File

@@ -1462,8 +1462,7 @@ make_icu_collator(const char *iculocstr,
/* could get here if a collation was created by a build with ICU */
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("ICU is not supported in this build"), \
errhint("You need to rebuild PostgreSQL using %s.", "--with-icu")));
errmsg("ICU is not supported in this build")));
#endif /* not USE_ICU */
}
@@ -2008,8 +2007,7 @@ check_icu_locale(const char *icu_locale)
#else
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("ICU is not supported in this build"), \
errhint("You need to rebuild PostgreSQL using %s.", "--with-icu")));
errmsg("ICU is not supported in this build")));
#endif
}

3
src/backend/utils/adt/xml.c
View File

@@ -220,8 +220,7 @@ const TableFuncRoutine XmlTableRoutine =
ereport(ERROR, \
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED), \
errmsg("unsupported XML feature"), \
errdetail("This functionality requires the server to be built with libxml support."), \
errhint("You need to rebuild PostgreSQL using %s.", "--with-libxml")))
errdetail("This functionality requires the server to be built with libxml support.")))
/* from SQL/XML:2008 section 4.9 */