database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-16 17:07:43 +03:00
Code Activity

Remove block information from description of some WAL records for GIN

Browse Source 
The WAL records XLOG_GIN_INSERT and XLOG_GIN_VACUUM_DATA_LEAF_PAGE
included some information about the blocks added to the record.

This information is already provided by XLogRecGetBlockRefInfo() with
much more details about the blocks included in each record, like the
compression information, for example.  This commit removes the block
information that existed in the record descriptions specific to GIN.

Author: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
Discussion: https://postgr.es/m/CALdSSPgk=9WRoXhZy5fdk+T1hiau7qbL_vn94w_L1N=gtEdbsg@mail.gmail.com
This commit is contained in:
Michael Paquier
2025-10-06 16:14:59 +09:00
parent a5b543258a
commit 7072a8855e
1 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/backend/access/rmgrdesc/gindesc.c
View File

@@ -99,14 +99,7 @@ gin_desc(StringInfo buf, XLogReaderState *record)
appendStringInfo(buf, " children: %u/%u",
leftChildBlkno, rightChildBlkno);
}
if (XLogRecHasBlockImage(record, 0))
{
if (XLogRecBlockImageApply(record, 0))
appendStringInfoString(buf, " (full page image)");
else
appendStringInfoString(buf, " (full page image, for WAL verification)");
}
else
if (!XLogRecHasBlockImage(record, 0))
{
char *payload = XLogRecGetBlockData(record, 0, NULL);
@@ -144,14 +137,7 @@ gin_desc(StringInfo buf, XLogReaderState *record)
break;
case XLOG_GIN_VACUUM_DATA_LEAF_PAGE:
{
if (XLogRecHasBlockImage(record, 0))
{
if (XLogRecBlockImageApply(record, 0))
appendStringInfoString(buf, " (full page image)");
else
appendStringInfoString(buf, " (full page image, for WAL verification)");
}
else
if (!XLogRecHasBlockImage(record, 0))
{
ginxlogVacuumDataLeafPage *xlrec =
(ginxlogVacuumDataLeafPage *) XLogRecGetBlockData(record, 0, NULL);