mirror of
https://github.com/postgres/postgres.git
synced 2025-07-05 07:21:24 +03:00
Fix misleading comments about background worker registration.
Since 6bc8ef0b7f
, the maximum number
of backends can't change as background workers are registered, but
these comments still reflect the way things worked prior to that.
Also, per recent discussion, some modules call SetConfigOption()
from _PG_init(). It's not entirely clear to me whether we want to
regard that as a fully supported operation, but since we know it's
a thing that happens, it at least deserves a mention in the comments,
so add that.
Nathan Bossart, reviewed by Anton A. Melnikov
Discussion: http://postgr.es/m/20220419154658.GA2487941@nathanxps13
This commit is contained in:
@ -1005,10 +1005,8 @@ PostmasterMain(int argc, char *argv[])
|
|||||||
LocalProcessControlFile(false);
|
LocalProcessControlFile(false);
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Register the apply launcher. Since it registers a background worker,
|
* Register the apply launcher. It's probably a good idea to call this
|
||||||
* it needs to be called before InitializeMaxBackends(), and it's probably
|
* before any modules had a chance to take the background worker slots.
|
||||||
* a good idea to call it before any modules had chance to take the
|
|
||||||
* background worker slots.
|
|
||||||
*/
|
*/
|
||||||
ApplyLauncherRegister();
|
ApplyLauncherRegister();
|
||||||
|
|
||||||
@ -1029,8 +1027,8 @@ PostmasterMain(int argc, char *argv[])
|
|||||||
#endif
|
#endif
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Now that loadable modules have had their chance to register background
|
* Now that loadable modules have had their chance to alter any GUCs,
|
||||||
* workers, calculate MaxBackends.
|
* calculate MaxBackends.
|
||||||
*/
|
*/
|
||||||
InitializeMaxBackends();
|
InitializeMaxBackends();
|
||||||
|
|
||||||
|
@ -538,9 +538,8 @@ pg_split_opts(char **argv, int *argcp, const char *optstr)
|
|||||||
/*
|
/*
|
||||||
* Initialize MaxBackends value from config options.
|
* Initialize MaxBackends value from config options.
|
||||||
*
|
*
|
||||||
* This must be called after modules have had the chance to register background
|
* This must be called after modules have had the chance to alter GUCs in
|
||||||
* workers in shared_preload_libraries, and before shared memory size is
|
* shared_preload_libraries and before shared memory size is determined.
|
||||||
* determined.
|
|
||||||
*
|
*
|
||||||
* Note that in EXEC_BACKEND environment, the value is passed down from
|
* Note that in EXEC_BACKEND environment, the value is passed down from
|
||||||
* postmaster to subprocesses via BackendParameters in SubPostmasterMain; only
|
* postmaster to subprocesses via BackendParameters in SubPostmasterMain; only
|
||||||
|
Reference in New Issue
Block a user