database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Add assertions for all the required index AM callbacks

Browse Source 
Similar checks are done for the mandatory table AM callbacks.  A portion
of the index AM callbacks are optional and can be NULL; the rest is
mandatory and is documented as such in the documentation and in amapi.h.

These checks are useful to detect quickly if all the mandatory callbacks
are defined when implementing a new index access method, as the
assertions are run when loading the AM.

Author: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/ME0P300MB0445795D31CEAB92C58B41FDB651A@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM
This commit is contained in:
Michael Paquier
2025-07-27 17:48:47 +09:00
parent db6461b1c9
commit 6f22a82a40
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/access/index/amapi.c
View File

@ -42,6 +42,19 @@ GetIndexAmRoutine(Oid amhandler)
elog(ERROR, "index access method handler function %u did not return an IndexAmRoutine struct",
amhandler);
/* Assert that all required callbacks are present. */
Assert(routine->ambuild != NULL);
Assert(routine->ambuildempty != NULL);
Assert(routine->aminsert != NULL);
Assert(routine->ambulkdelete != NULL);
Assert(routine->amvacuumcleanup != NULL);
Assert(routine->amcostestimate != NULL);
Assert(routine->amoptions != NULL);
Assert(routine->amvalidate != NULL);
Assert(routine->ambeginscan != NULL);
Assert(routine->amrescan != NULL);
Assert(routine->amendscan != NULL);
return routine;
}