database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-27 22:56:53 +03:00
Code

In the integer-datetimes case, date2timestamp and date2timestamptz need

Browse Source 
to check for overflow because the legal range of type date is actually
wider than timestamp's.  Problem found by Neil Conway.
This commit is contained in:
Tom Lane 2007-09-26 01:10:42 +00:00
parent 93407d3998
commit 6f21c57a97
1 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/backend/utils/adt/date.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/adt/date.c,v 1.135 2007/08/04 01:26:53 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/adt/date.c,v 1.136 2007/09/26 01:10:42 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -336,16 +336,27 @@ date_mii(PG_FUNCTION_ARGS)
* time zone * time zone
*/ */
static Timestamp
date2timestamp(DateADT dateVal)
{
Timestamp result;
#ifdef HAVE_INT64_TIMESTAMP #ifdef HAVE_INT64_TIMESTAMP
/* date is days since 2000, timestamp is microseconds since same... */ /* date is days since 2000, timestamp is microseconds since same... */
#define date2timestamp(dateVal) \ result = dateVal * USECS_PER_DAY;
((Timestamp) ((dateVal) * USECS_PER_DAY)) /* Date's range is wider than timestamp's, so must check for overflow */
if (result / USECS_PER_DAY != dateVal)
ereport(ERROR,
(errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),
errmsg("date out of range for timestamp")));
#else #else
/* date is days since 2000, timestamp is seconds since same... */ /* date is days since 2000, timestamp is seconds since same... */
#define date2timestamp(dateVal) \ result = dateVal * (double) SECS_PER_DAY;
((Timestamp) ((dateVal) * (double)SECS_PER_DAY))
#endif #endif
return result;
}
static TimestampTz static TimestampTz
date2timestamptz(DateADT dateVal) date2timestamptz(DateADT dateVal)
{ {
@ -364,6 +375,11 @@ date2timestamptz(DateADT dateVal)
#ifdef HAVE_INT64_TIMESTAMP #ifdef HAVE_INT64_TIMESTAMP
result = dateVal * USECS_PER_DAY + tz * USECS_PER_SEC; result = dateVal * USECS_PER_DAY + tz * USECS_PER_SEC;
/* Date's range is wider than timestamp's, so must check for overflow */
if ((result - tz * USECS_PER_SEC) / USECS_PER_DAY != dateVal)
ereport(ERROR,
(errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),
errmsg("date out of range for timestamp")));
#else #else
result = dateVal * (double) SECS_PER_DAY + tz; result = dateVal * (double) SECS_PER_DAY + tz;
#endif #endif