database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-08 11:42:09 +03:00
Code Activity

Remove Ident nodetype in favor of using String nodes; this fixes some

Browse Source 
latent wrong-struct-type bugs and makes the coding style more uniform,
since the majority of places working with lists of column names were
already using Strings not Idents.  While at it, remove vestigial
support for Stream node type, and otherwise-unreferenced nodes.h entries
for T_TupleCount and T_BaseNode.
NB: full recompile is recommended due to changes of Node type numbers.
This shouldn't force an initdb though.
This commit is contained in:
Tom Lane
2002-08-19 15:08:47 +00:00
parent 10b374aecf
commit 6ebc90b045
11 changed files with 73 additions and 267 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/backend/nodes/copyfuncs.c
View File

@ -15,7 +15,7 @@
* Portions Copyright (c) 1994, Regents of the University of California
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.203 2002/08/19 00:40:14 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/nodes/copyfuncs.c,v 1.204 2002/08/19 15:08:46 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -1435,28 +1435,6 @@ _copyJoinInfo(JoinInfo *from)
return newnode;
}
static Stream *
_copyStream(Stream *from)
{
Stream *newnode = makeNode(Stream);
newnode->pathptr = from->pathptr;
newnode->cinfo = from->cinfo;
newnode->clausetype = from->clausetype;
newnode->upstream = (StreamPtr) NULL; /* only copy nodes
* downwards! */
Node_Copy(from, newnode, downstream);
if (newnode->downstream)
((Stream *) newnode->downstream)->upstream = (Stream *) newnode;
newnode->groupup = from->groupup;
newnode->groupcost = from->groupcost;
newnode->groupsel = from->groupsel;
return newnode;
}
/* ****************************************************************
* parsenodes.h copy functions
* ****************************************************************
@ -1593,16 +1571,6 @@ _copyAConst(A_Const *from)
return newnode;
}
static Ident *
_copyIdent(Ident *from)
{
Ident *newnode = makeNode(Ident);
newnode->name = pstrdup(from->name);
return newnode;
}
static FuncCall *
_copyFuncCall(FuncCall *from)
{
@ -2890,9 +2858,6 @@ copyObject(void *from)
case T_JoinInfo:
retval = _copyJoinInfo(from);
break;
case T_Stream:
retval = _copyStream(from);
break;
case T_IndexOptInfo:
retval = _copyIndexOptInfo(from);
break;
@ -3131,9 +3096,6 @@ copyObject(void *from)
case T_A_Const:
retval = _copyAConst(from);
break;
case T_Ident:
retval = _copyIdent(from);
break;
case T_FuncCall:
retval = _copyFuncCall(from);
break;