database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

logical decoding: Tell reorderbuffer about all xids.

Browse Source 
Logical decoding's reorderbuffer keeps transactions in an LSN ordered
list for efficiency. To make that's efficiently possible upper-level
xids are forced to be logged before nested subtransaction xids.  That
only works though if these records are all looked at: Unfortunately we
didn't do so for e.g. row level locks, which are otherwise uninteresting
for logical decoding.

This could lead to errors like:
"ERROR: subxact logged without previous toplevel record".

It's not sufficient to just look at row locking records, the xid could
appear first due to a lot of other types of records (which will trigger
the transaction to be marked logged with MarkCurrentTransactionIdLoggedIfAny).
So invent infrastructure to tell reorderbuffer about xids seen, when
they'd otherwise not pass through reorderbuffer.c.

Reported-By: Jarred Ward
Bug: #13844
Discussion: 20160105033249.1087.66040@wrigleys.postgresql.org
Backpatch: 9.4, where logical decoding was added
This commit is contained in:
Andres Freund
2016-03-05 18:02:20 -08:00
parent f95f1ce003
commit 6e759cefe8
7 changed files with 108 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/backend/replication/logical/reorderbuffer.c
View File

@ -1741,16 +1741,21 @@ ReorderBufferForget(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn)
/*
* Check whether a transaction is already known in this module.xs
* Tell reorderbuffer about an xid seen in the WAL stream. Has to be called at
* least once for every xid in XLogRecord->xl_xid (other places in records
* may, but do not have to be passed through here).
*
* Reorderbuffer keeps some datastructures about transactions in LSN order,
* for efficiency. To do that it has to know about when transactions are seen
* first in the WAL. As many types of records are not actually interesting for
* logical decoding, they do not necessarily pass though here.
*/
bool
ReorderBufferIsXidKnown(ReorderBuffer *rb, TransactionId xid)
void
ReorderBufferProcessXid(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn)
{
ReorderBufferTXN *txn;
txn = ReorderBufferTXNByXid(rb, xid, false, NULL, InvalidXLogRecPtr,
false);
return txn != NULL;
/* many records won't have an xid assigned, centralize check here */
if (xid != InvalidTransactionId)
ReorderBufferTXNByXid(rb, xid, true, NULL, lsn, true);
}
/*