database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-10 09:21:54 +03:00
Code

Improve error message when an FDW doesn't support WHERE CURRENT OF.

Browse Source 
If an FDW fails to take special measures with a CurrentOfExpr, we will
end up trying to execute it as an ordinary qual, which was being treated
as a purely internal failure condition.  Provide a more user-oriented
error message for such cases.
This commit is contained in:
Tom Lane 2013-04-19 16:14:56 -04:00
parent 3353583d7e
commit 6e481ebff6
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/executor/execQual.c
View File

@ -4257,16 +4257,20 @@ ExecEvalArrayCoerceExpr(ArrayCoerceExprState *astate,
/* ---------------------------------------------------------------- /* ----------------------------------------------------------------
* ExecEvalCurrentOfExpr * ExecEvalCurrentOfExpr
* *
* The planner must convert CURRENT OF into a TidScan qualification. * The planner should convert CURRENT OF into a TidScan qualification, or some
* So, we have to be able to do ExecInitExpr on a CurrentOfExpr, * other special handling in a ForeignScan node. So we have to be able to do
* but we shouldn't ever actually execute it. * ExecInitExpr on a CurrentOfExpr, but we shouldn't ever actually execute it.
* If we get here, we suppose we must be dealing with CURRENT OF on a foreign
* table whose FDW doesn't handle it, and complain accordingly.
* ---------------------------------------------------------------- * ----------------------------------------------------------------
*/ */
static Datum static Datum
ExecEvalCurrentOfExpr(ExprState *exprstate, ExprContext *econtext, ExecEvalCurrentOfExpr(ExprState *exprstate, ExprContext *econtext,
bool *isNull, ExprDoneCond *isDone) bool *isNull, ExprDoneCond *isDone)
{ {
elog(ERROR, "CURRENT OF cannot be executed"); ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("WHERE CURRENT OF is not supported for this table type")));
return 0; /* keep compiler quiet */ return 0; /* keep compiler quiet */
} }