database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-05 09:19:17 +03:00
Code

Repair unstable regression test.

Browse Source 
Commit 0c882e52a tried to force table atest12 to have more-accurate-
than-default statistics; but transiently setting default_statistics_target
isn't enough for that, because autovacuum could come along and overwrite
the stats later.  This evidently explains some intermittent buildfarm
failures we've seen since then.  Repair by disabling autovac on this table.

Thanks to David Rowley for correctly diagnosing the cause.

Discussion: https://postgr.es/m/CA+hUKG+OUkQSOUTg=qo=S=fWa_tbm99i7rB7mfbHz1SYm4v-jQ@mail.gmail.com
This commit is contained in:
Tom Lane 2020-06-09 01:17:59 -04:00
parent 2174d40117
commit 6df8fb391b
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/test/regress/expected/privileges.out
View File

@ -191,7 +191,8 @@ CREATE TABLE atest12 as
SELECT x AS a, 10001 - x AS b FROM generate_series(1,10000) x; SELECT x AS a, 10001 - x AS b FROM generate_series(1,10000) x;
CREATE INDEX ON atest12 (a); CREATE INDEX ON atest12 (a);
CREATE INDEX ON atest12 (abs(a)); CREATE INDEX ON atest12 (abs(a));
-- results below depend on having quite accurate stats for atest12 -- results below depend on having quite accurate stats for atest12, so...
ALTER TABLE atest12 SET (autovacuum_enabled = off);
SET default_statistics_target = 10000; SET default_statistics_target = 10000;
VACUUM ANALYZE atest12; VACUUM ANALYZE atest12;
RESET default_statistics_target; RESET default_statistics_target;

3
src/test/regress/sql/privileges.sql
View File

@ -136,7 +136,8 @@ CREATE TABLE atest12 as
SELECT x AS a, 10001 - x AS b FROM generate_series(1,10000) x; SELECT x AS a, 10001 - x AS b FROM generate_series(1,10000) x;
CREATE INDEX ON atest12 (a); CREATE INDEX ON atest12 (a);
CREATE INDEX ON atest12 (abs(a)); CREATE INDEX ON atest12 (abs(a));
-- results below depend on having quite accurate stats for atest12 -- results below depend on having quite accurate stats for atest12, so...
ALTER TABLE atest12 SET (autovacuum_enabled = off);
SET default_statistics_target = 10000; SET default_statistics_target = 10000;
VACUUM ANALYZE atest12; VACUUM ANALYZE atest12;
RESET default_statistics_target; RESET default_statistics_target;