database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Change internal integer representation of Value node

Browse Source 
A Value node would store an integer as a long.  This causes needless
portability risks, as long can be of varying sizes.  Change it to use
int instead.  All code using this was already careful to only store
32-bit values anyway.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
This commit is contained in:
Peter Eisentraut
2018-03-12 12:17:58 -04:00
parent 377b5ac484
commit 6cf86f4354
7 changed files with 17 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/interfaces/ecpg/preproc/pgc.l
View File

@@ -732,12 +732,9 @@ cppline {space}*#([^i][A-Za-z]*|{if}|{ifdef}|{ifndef}|{import})((\/\*[^*/]*\*+
errno = 0;
val = strtol((char *)yytext, &endptr,10);
if (*endptr != '\0' || errno == ERANGE
#ifdef HAVE_LONG_INT_64
/* if long > 32 bits, check for overflow of int4 */
|| val != (long) ((int32) val)
#endif
)
if (*endptr != '\0' || errno == ERANGE ||
/* check for overflow of int */
val != (int) val)
{
errno = 0;
base_yylval.str = mm_strdup(yytext);