database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-31 22:04:40 +03:00
Code Activity

Remove error report from pq_endmessage when pq_putmessage fails. The

Browse Source 
only possible failure is in pq_flush, which will log a (better!) report
anyway --- so pq_endmessage is just cluttering the log with a redundant
entry.  This matters when a client crashes partway through a large query,
since we will emit many broken-pipe reports before finishing the query
and exiting.
This commit is contained in:
Tom Lane
2001-04-16 01:46:57 +00:00
parent c8e05affe4
commit 6ccb2af725
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/backend/libpq/pqformat.c
View File

@ -16,7 +16,7 @@
* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $Id: pqformat.c,v 1.16 2001/01/24 19:42:56 momjian Exp $ * $Id: pqformat.c,v 1.17 2001/04/16 01:46:57 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -213,13 +213,8 @@ pq_sendint(StringInfo buf, int i, int b)
void void
pq_endmessage(StringInfo buf) pq_endmessage(StringInfo buf)
{ {
if (pq_putmessage('\0', buf->data, buf->len)) (void) pq_putmessage('\0', buf->data, buf->len);
{ /* no need to complain about any failure, since pqcomm.c already did */
snprintf(PQerrormsg, PQERRORMSG_LENGTH,
"FATAL: pq_endmessage failed: errno=%d\n", errno);
fputs(PQerrormsg, stderr);
pqdebug("%s", PQerrormsg);
}
pfree(buf->data); pfree(buf->data);
buf->data = NULL; buf->data = NULL;
} }