database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-22 02:52:08 +03:00
Code Activity

Convert misleading while loop into an if condition

Browse Source 
This seems to be leftover from ea15e1867 and from when we used to evaluate
SRFs at each node.

Since there is an unconditional "return" at the end of the loop body, only
1 loop is ever possible, so we can just change this into an if condition.

There is no actual bug being fixed here so no back-patch. It seems fine to
just fix this anomaly in master only.

Author: Greg Nancarrow
Discussion: https://postgr.es/m/CAJcOf-d7T1q0az-D8evWXnsuBZjigT04WkV5hCAOEJQZRWy28w@mail.gmail.com
This commit is contained in:
David Rowley
2021-05-14 12:26:11 +12:00
parent fbe9b80610
commit 6cb93beddd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/executor/nodeResult.c
View File

@ -103,7 +103,7 @@ ExecResult(PlanState *pstate)
* called, OR that we failed the constant qual check. Either way, now we * called, OR that we failed the constant qual check. Either way, now we
* are through. * are through.
*/ */
while (!node->rs_done) if (!node->rs_done)
{ {
outerPlan = outerPlanState(node); outerPlan = outerPlanState(node);