database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-22 23:02:54 +03:00
Code

Fix redundant error messages in client tools

Browse Source 
A few client tools duplicate error messages already provided by libpq.

Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com
This commit is contained in:
Peter Eisentraut 2020-11-07 22:15:52 +01:00
parent eed4356fad
commit 6be725e701
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/bin/pg_basebackup/streamutil.c
View File

@ -200,8 +200,7 @@ GetConnection(void)
if (PQstatus(tmpconn) != CONNECTION_OK) if (PQstatus(tmpconn) != CONNECTION_OK)
{ {
pg_log_error("could not connect to server: %s", pg_log_error("%s", PQerrorMessage(tmpconn));
PQerrorMessage(tmpconn));
PQfinish(tmpconn); PQfinish(tmpconn);
free(values); free(values);
free(keywords); free(keywords);

3
src/bin/pg_rewind/pg_rewind.c
View File

@ -282,8 +282,7 @@ main(int argc, char **argv)
conn = PQconnectdb(connstr_source); conn = PQconnectdb(connstr_source);
if (PQstatus(conn) == CONNECTION_BAD) if (PQstatus(conn) == CONNECTION_BAD)
pg_fatal("could not connect to server: %s", pg_fatal("%s", PQerrorMessage(conn));
PQerrorMessage(conn));
if (showprogress) if (showprogress)
pg_log_info("connected to server"); pg_log_info("connected to server");

2
src/bin/psql/startup.c
View File

@ -295,7 +295,7 @@ main(int argc, char *argv[])
if (PQstatus(pset.db) == CONNECTION_BAD) if (PQstatus(pset.db) == CONNECTION_BAD)
{ {
pg_log_error("could not connect to server: %s", PQerrorMessage(pset.db)); pg_log_error("%s", PQerrorMessage(pset.db));
PQfinish(pset.db); PQfinish(pset.db);
exit(EXIT_BADCONN); exit(EXIT_BADCONN);
} }