database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Fix function-header comments in planner.c

Browse Source 
In b5635948ab, a couple of function header comments weren't changed, or
weren't changed correctly, to reflect the arguments being passed into
the functions.  Specifically, get_number_of_groups() had the wrong
argument name in the commit and create_grouping_paths() wasn't
updated even though the arguments had been changed.

The issue with create_grouping_paths() was noticed by Ashutosh Bapat,
while I discovered the issue with get_number_of_groups() by looking to
see if there were any similar issues from that commit.

Discussion: https://postgr.es/m/CAFjFpRcbp4702jcp387PExt3fNCt62QJN8++DQGwBhsW6wRHWA@mail.gmail.com
This commit is contained in:
Stephen Frost
2018-03-14 13:51:15 -04:00
parent 1f7b8967ef
commit 6b960aae90
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/optimizer/plan/planner.c
View File

@@ -3504,7 +3504,7 @@ standard_qp_callback(PlannerInfo *root, void *extra)
* Estimate number of groups produced by grouping clauses (1 if not grouping) * Estimate number of groups produced by grouping clauses (1 if not grouping)
* *
* path_rows: number of output rows from scan/join step * path_rows: number of output rows from scan/join step
* gsets: grouping set data, or NULL if not doing grouping sets * gd: grouping sets data including list of grouping sets and their clauses
* *
* If doing grouping sets, we also annotate the gsets data with the estimates * If doing grouping sets, we also annotate the gsets data with the estimates
* for each set and each individual rollup list, with a view to later * for each set and each individual rollup list, with a view to later
@@ -3659,9 +3659,7 @@ estimate_hashagg_tablesize(Path *path, const AggClauseCosts *agg_costs,
* input_rel: contains the source-data Paths * input_rel: contains the source-data Paths
* target: the pathtarget for the result Paths to compute * target: the pathtarget for the result Paths to compute
* agg_costs: cost info about all aggregates in query (in AGGSPLIT_SIMPLE mode) * agg_costs: cost info about all aggregates in query (in AGGSPLIT_SIMPLE mode)
* rollup_lists: list of grouping sets, or NIL if not doing grouping sets * gd: grouping sets data including list of grouping sets and their clauses
* rollup_groupclauses: list of grouping clauses for grouping sets,
* or NIL if not doing grouping sets
* *
* Note: all Paths in input_rel are expected to return the target computed * Note: all Paths in input_rel are expected to return the target computed
* by make_group_input_target. * by make_group_input_target.