mirror of
https://github.com/postgres/postgres.git
synced 2025-07-28 23:42:10 +03:00
Lock down regression testing temporary clusters on Windows.
Use SSPI authentication to allow connections exclusively from the OS
user that launched the test suite. This closes on Windows the
vulnerability that commit be76a6d39e
closed on other platforms. Users of "make installcheck" or custom test
harnesses can run "pg_regress --config-auth=DATADIR" to activate the
same authentication configuration that "make check" would use.
Back-patch to 9.0 (all supported versions).
Security: CVE-2014-0067
This commit is contained in:
@ -17,13 +17,20 @@ set -e
|
||||
unset MAKEFLAGS
|
||||
unset MAKELEVEL
|
||||
|
||||
# Run a given "initdb" binary and overlay the regression testing
|
||||
# authentication configuration.
|
||||
standard_initdb() {
|
||||
"$1" -N
|
||||
../../src/test/regress/pg_regress --config-auth "$PGDATA"
|
||||
}
|
||||
|
||||
# Establish how the server will listen for connections
|
||||
testhost=`uname -s`
|
||||
|
||||
case $testhost in
|
||||
MINGW*)
|
||||
LISTEN_ADDRESSES="localhost"
|
||||
PGHOST=""; unset PGHOST
|
||||
PGHOST=localhost
|
||||
;;
|
||||
*)
|
||||
LISTEN_ADDRESSES=""
|
||||
@ -49,11 +56,11 @@ case $testhost in
|
||||
trap 'rm -rf "$PGHOST"' 0
|
||||
trap 'exit 3' 1 2 13 15
|
||||
fi
|
||||
export PGHOST
|
||||
;;
|
||||
esac
|
||||
|
||||
POSTMASTER_OPTS="-F -c listen_addresses=$LISTEN_ADDRESSES -k \"$PGHOST\""
|
||||
export PGHOST
|
||||
|
||||
temp_root=$PWD/tmp_check
|
||||
|
||||
@ -141,7 +148,7 @@ export EXTRA_REGRESS_OPTS
|
||||
# enable echo so the user can see what is being executed
|
||||
set -x
|
||||
|
||||
$oldbindir/initdb -N
|
||||
standard_initdb "$oldbindir"/initdb
|
||||
$oldbindir/pg_ctl start -l "$logdir/postmaster1.log" -o "$POSTMASTER_OPTS" -w
|
||||
if "$MAKE" -C "$oldsrc" installcheck; then
|
||||
pg_dumpall -f "$temp_root"/dump1.sql || pg_dumpall1_status=$?
|
||||
@ -181,7 +188,7 @@ fi
|
||||
|
||||
PGDATA=$BASE_PGDATA
|
||||
|
||||
initdb -N
|
||||
standard_initdb 'initdb'
|
||||
|
||||
pg_upgrade $PG_UPGRADE_OPTS -d "${PGDATA}.old" -D "${PGDATA}" -b "$oldbindir" -B "$bindir" -p "$PGPORT" -P "$PGPORT"
|
||||
|
||||
|
Reference in New Issue
Block a user