database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-02 11:44:50 +03:00
Code

Try to fix memory barriers on x86_64.

Browse Source 
%esp is no good; must use %rsp there.
This commit is contained in:
Robert Haas 2011-10-07 23:32:30 -04:00
parent a2822fb933
commit 6a6082c27c
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/include/storage/barrier.h
View File

@ -62,14 +62,24 @@ extern slock_t dummy_spinlock;
/* This works on any architecture, since it's only talking to GCC itself. */ /* This works on any architecture, since it's only talking to GCC itself. */
#define pg_compiler_barrier() __asm__ __volatile__("" : : : "memory") #define pg_compiler_barrier() __asm__ __volatile__("" : : : "memory")
#if defined(__i386__) || defined(__x86_64__) /* 32 or 64 bit x86 */ #if defined(__i386__)
/* /*
* x86 and x86_64 do not allow loads to be reorded with other loads, or * i386 does not allow loads to be reorded with other loads, or stores to be
* stores to be reordered with other stores, but a load can be performed * reordered with other stores, but a load can be performed before a subsequent
* before a subsequent store. * store.
* *
* "lock; addl" has worked for longer than "mfence". * "lock; addl" has worked for longer than "mfence".
*/
#define pg_memory_barrier() \
__asm__ __volatile__ ("lock; addl $0,0(%%esp)" : : : "memory")
#define pg_read_barrier() pg_compiler_barrier()
#define pg_write_barrier() pg_compiler_barrier()
#elif defined(__x86_64__) /* 64 bit x86 */
/*
* x86_64 has similar ordering characteristics to i386.
* *
* Technically, some x86-ish chips support uncached memory access and/or * Technically, some x86-ish chips support uncached memory access and/or
* special instructions that are weakly ordered. In those cases we'd need * special instructions that are weakly ordered. In those cases we'd need
@ -77,7 +87,7 @@ extern slock_t dummy_spinlock;
* do those things, a compiler barrier should be enough. * do those things, a compiler barrier should be enough.
*/ */
#define pg_memory_barrier() \ #define pg_memory_barrier() \
__asm__ __volatile__ ("lock; addl $0,0(%%esp)" : : : "memory") __asm__ __volatile__ ("lock; addl $0,0(%%rsp)" : : : "memory")
#define pg_read_barrier() pg_compiler_barrier() #define pg_read_barrier() pg_compiler_barrier()
#define pg_write_barrier() pg_compiler_barrier() #define pg_write_barrier() pg_compiler_barrier()