From 69892d58c9881acac934629187c7301f8e296eb4 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 31 Dec 2015 17:59:10 -0500 Subject: [PATCH] Add a comment noting that FDWs don't have to implement EXCEPT or LIMIT TO. postgresImportForeignSchema pays attention to IMPORT's EXCEPT and LIMIT TO options, but only as an efficiency hack, not for correctness' sake. The FDW documentation does explain that, but someone using postgres_fdw.c as a coding guide might not remember it, so let's add a comment here. Per question from Regina Obe. --- contrib/postgres_fdw/postgres_fdw.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index 8cf5df8f571..775eaa07da8 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -2675,7 +2675,11 @@ postgresImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid) /* * Fetch all table data from this schema, possibly restricted by - * EXCEPT or LIMIT TO. + * EXCEPT or LIMIT TO. (We don't actually need to pay any attention + * to EXCEPT/LIMIT TO here, because the core code will filter the + * statements we return according to those lists anyway. But it + * should save a few cycles to not process excluded tables in the + * first place.) * * Note: because we run the connection with search_path restricted to * pg_catalog, the format_type() and pg_get_expr() outputs will always