database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-14 18:42:34 +03:00
Code Activity

Prevent continuing disk-space bloat when profiling (with PROFILE_PID_DIR

Browse Source 
enabled) and autovacuum is on.  Since there will be a steady stream of autovac
worker processes exiting and dropping gmon.out files, allowing them to make
separate subdirectories results in serious bloat; and it seems unlikely that
anyone will care about those profiles anyway.  Limit the damage by forcing all
autovac workers to dump in one subdirectory, PGDATA/gprof/avworker/.

Per report from Jšrg Beyer and subsequent discussion.
This commit is contained in:
Tom Lane
2007-11-04 17:55:15 +00:00
parent a2899ebdc2
commit 69500b05d6
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/storage/ipc/ipc.c
View File

@ -13,7 +13,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/storage/ipc/ipc.c,v 1.97 2007/07/25 19:58:56 tgl Exp $ * $PostgreSQL: pgsql/src/backend/storage/ipc/ipc.c,v 1.98 2007/11/04 17:55:15 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -24,6 +24,9 @@
#include <sys/stat.h> #include <sys/stat.h>
#include "miscadmin.h" #include "miscadmin.h"
#ifdef PROFILE_PID_DIR
#include "postmaster/autovacuum.h"
#endif
#include "storage/ipc.h" #include "storage/ipc.h"
@ -126,6 +129,11 @@ proc_exit(int code)
* $PGDATA/gprof/8845/gmon.out * $PGDATA/gprof/8845/gmon.out
* ... * ...
* *
* To avoid undesirable disk space bloat, autovacuum workers are
* discriminated against: all their gmon.out files go into the same
* subdirectory. Without this, an installation that is "just sitting
* there" nonetheless eats megabytes of disk space every few seconds.
*
* Note that we do this here instead of in an on_proc_exit() * Note that we do this here instead of in an on_proc_exit()
* callback because we want to ensure that this code executes * callback because we want to ensure that this code executes
* last - we don't want to interfere with any other on_proc_exit() * last - we don't want to interfere with any other on_proc_exit()
@ -133,7 +141,10 @@ proc_exit(int code)
*/ */
char gprofDirName[32]; char gprofDirName[32];
snprintf(gprofDirName, 32, "gprof/%d", (int) getpid()); if (IsAutoVacuumWorkerProcess())
snprintf(gprofDirName, 32, "gprof/avworker");
else
snprintf(gprofDirName, 32, "gprof/%d", (int) getpid());
mkdir("gprof", 0777); mkdir("gprof", 0777);
mkdir(gprofDirName, 0777); mkdir(gprofDirName, 0777);