database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-12 21:01:52 +03:00
Code Activity

Further code review for pg_lsn data type.

Browse Source 
Change input function error messages to be more consistent with what is
done elsewhere.  Remove a bunch of redundant type casts, so that the
compiler will warn us if we screw up.  Don't pass LSNs by value on
platforms where a Datum is only 32 bytes, per buildfarm.  Move macros
for packing and unpacking LSNs to pg_lsn.h so that we can include
access/xlogdefs.h, to avoid an unsatisfied dependency on XLogRecPtr.
This commit is contained in:
Robert Haas
2014-02-19 10:06:59 -05:00
parent 844a28a9dd
commit 694e3d139a
6 changed files with 32 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/include/postgres.h
View File

@ -483,20 +483,6 @@ typedef Datum *DatumPtr;
#define ObjectIdGetDatum(X) ((Datum) SET_4_BYTES(X))
/*
* DatumGetLSN
* Returns PostgreSQL log sequence number of a datum.
*/
#define DatumGetLSN(X) ((XLogRecPtr) GET_8_BYTES(X))
/*
* LSNGetDatum
* Returns datum representation for a PostgreSQL log sequence number.
*/
#define LSNGetDatum(X) ((Datum) SET_8_BYTES(X))
/*
* DatumGetTransactionId
* Returns transaction identifier value of a datum.