From 6929e133b309d5d4568b5ed25b136935f63be618 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Fri, 8 Mar 2024 22:50:20 +0100 Subject: [PATCH] Replace perror with custom postgres logging perror() is not used in postgres anymore out of policy, this replaces the final callsites with the custom postgres logging framework. Reviewed-by: Tom Lane Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/m/89B00F63-40F7-4D82-8353-DC9CABBAC1D1@yesql.se --- src/common/exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/common/exec.c b/src/common/exec.c index da929f15b95..bcd5b71101e 100644 --- a/src/common/exec.c +++ b/src/common/exec.c @@ -378,7 +378,8 @@ pipe_read_line(char *cmd) errno = 0; if ((pipe_cmd = popen(cmd, "r")) == NULL) { - perror("popen failure"); + log_error(errcode(ERRCODE_SYSTEM_ERROR), + _("could not execute command \"%s\": %m"), cmd); return NULL; }