database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-11 05:41:32 +03:00
Code

Upon closer inspection, Greg's psql tab completion patch leaks memory.

Browse Source 
Fix the leak, and add a comment to note that the return value of
previous_word must be free'd.
This commit is contained in:
Neil Conway 2005-05-18 05:01:10 +00:00
parent 4c1f9a0f0b
commit 6910032a56
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/bin/psql/tab-complete.c
View File

@ -3,7 +3,7 @@
* *
* Copyright (c) 2000-2005, PostgreSQL Global Development Group * Copyright (c) 2000-2005, PostgreSQL Global Development Group
* *
* $PostgreSQL: pgsql/src/bin/psql/tab-complete.c,v 1.128 2005/05/18 04:47:40 neilc Exp $ * $PostgreSQL: pgsql/src/bin/psql/tab-complete.c,v 1.129 2005/05/18 05:01:10 neilc Exp $
*/ */
/*---------------------------------------------------------------------- /*----------------------------------------------------------------------
@ -1802,6 +1802,7 @@ psql_completion(char *text, int start, int end)
free(prev2_wd); free(prev2_wd);
free(prev3_wd); free(prev3_wd);
free(prev4_wd); free(prev4_wd);
free(prev5_wd);
/* Return our Grand List O' Matches */ /* Return our Grand List O' Matches */
return matches; return matches;
@ -2168,8 +2169,10 @@ exec_query(const char *query)
/* Return the word (space delimited) before point. Set skip > 0 to skip that /*
many words; e.g. skip=1 finds the word before the previous one. * Return the word (space delimited) before point. Set skip > 0 to
* skip that many words; e.g. skip=1 finds the word before the
* previous one. Return value is NULL or a malloc'ed string.
*/ */
static char * static char *
previous_word(int point, int skip) previous_word(int point, int skip)