database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Redefine the lp_flags field of item pointers as having four states, rather

Browse Source 
than two independent bits (one of which was never used in heap pages anyway,
or at least hadn't been in a very long time).  This gives us flexibility to
add the HOT notions of redirected and dead item pointers without requiring
anything so klugy as magic values of lp_off and lp_len.  The state values
are chosen so that for the states currently in use (pre-HOT) there is no
change in the physical representation.
This commit is contained in:
Tom Lane
2007-09-12 22:10:26 +00:00
parent eb0a7735ba
commit 6889303531
31 changed files with 278 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
contrib/pageinspect/heapfuncs.c
View File

@ -18,7 +18,7 @@
* Copyright (c) 2007, PostgreSQL Global Development Group
*
* IDENTIFICATION
* $PostgreSQL: pgsql/contrib/pageinspect/heapfuncs.c,v 1.1 2007/05/17 19:11:24 momjian Exp $
* $PostgreSQL: pgsql/contrib/pageinspect/heapfuncs.c,v 1.2 2007/09/12 22:10:25 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -156,15 +156,15 @@ heap_page_items(PG_FUNCTION_ARGS)
* could be corrupt in many other ways, but at least we won't
* crash.
*/
if ((lp_len >= sizeof(HeapTupleHeader)) &&
(lp_offset == MAXALIGN(lp_offset)) &&
(lp_offset + lp_len <= raw_page_size) &&
ItemIdIsUsed(id))
if (ItemIdHasStorage(id) &&
lp_len >= sizeof(HeapTupleHeader) &&
lp_offset == MAXALIGN(lp_offset) &&
lp_offset + lp_len <= raw_page_size)
{
HeapTupleHeader tuphdr;
int bits_len;
/* Extract infromation from the tuple header */
/* Extract information from the tuple header */
tuphdr = (HeapTupleHeader) PageGetItem(page, id);