database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-14 18:42:34 +03:00
Code Activity

Fix non-portable use of round().

Browse Source 
round() is from C99.  Use rint() instead.  There are behavioral
differences between round() and rint(), but they should not matter to
the Bloom filter optimal_k() function.  We already assume POSIX
behavior for rint(), so there is no question of rint() not using
"rounds towards nearest" as its rounding mode.

Cleanup from commit 51bc271790.

Per buildfarm member thrips.

Author: Peter Geoghegan
Discussion: https://postgr.es/m/CAH2-Wzn76eCGUonARy-wrVtMHsf+4cvbK_oJAWTLfORTU5ki0w@mail.gmail.com
This commit is contained in:
Andres Freund
2018-03-31 20:26:47 -07:00
parent 7f563c09f8
commit 686d399f2b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/lib/bloomfilter.c
View File

@ -240,7 +240,7 @@ my_bloom_power(uint64 target_bitset_bits)
static int static int
optimal_k(uint64 bitset_bits, int64 total_elems) optimal_k(uint64 bitset_bits, int64 total_elems)
{ {
int k = round(log(2.0) * bitset_bits / total_elems); int k = rint(log(2.0) * bitset_bits / total_elems);
return Max(1, Min(k, MAX_HASH_FUNCS)); return Max(1, Min(k, MAX_HASH_FUNCS));
} }