From 6844d3275ac6b3c35d824f49362d3fe59b30f26b Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 29 Aug 2023 08:58:56 +0200 Subject: [PATCH] Remove useless if condition We can call GetAttributeCompression() with a NULL argument. It handles that internally already. This change makes all the callers of GetAttributeCompression() uniform. Reviewed-by: Alvaro Herrera Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org --- src/backend/commands/tablecmds.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 48f17a34039..d097da3c78e 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -944,11 +944,7 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId, attr->attidentity = colDef->identity; attr->attgenerated = colDef->generated; - - if (colDef->compression) - attr->attcompression = GetAttributeCompression(attr->atttypid, - colDef->compression); - + attr->attcompression = GetAttributeCompression(attr->atttypid, colDef->compression); if (colDef->storage_name) attr->attstorage = GetAttributeStorage(attr->atttypid, colDef->storage_name); }