database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-29 13:56:47 +03:00
Code

waldump: fix use-after-free in search_directory().

Browse Source 
After closedir() dirent->d_name is not valid anymore. As there alerady are a
few places relying on the limited lifetime of pg_waldump, do so here as well,
and just pg_strdup() the string.

The bug was introduced in fc49e24fa69a.

Found by UBSan, run locally.

Backpatch: 11-, like fc49e24fa69 itself.
This commit is contained in:
Andres Freund 2022-03-23 16:38:43 -07:00
parent 3f7a59c59b
commit 6839aa7a69
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/pg_waldump/pg_waldump.c
View File

@ -177,7 +177,7 @@ search_directory(const char *directory, const char *fname)
if (IsXLogFileName(xlde->d_name)) if (IsXLogFileName(xlde->d_name))
{ {
fd = open_file_in_directory(directory, xlde->d_name); fd = open_file_in_directory(directory, xlde->d_name);
fname = xlde->d_name; fname = pg_strdup(xlde->d_name);
break; break;
} }
} }