mirror of
https://github.com/postgres/postgres.git
synced 2025-07-05 07:21:24 +03:00
Goodbye ABORT. Hello ERROR for all errors.
This commit is contained in:
8
src/backend/utils/cache/catcache.c
vendored
8
src/backend/utils/cache/catcache.c
vendored
@ -7,7 +7,7 @@
|
||||
*
|
||||
*
|
||||
* IDENTIFICATION
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/catcache.c,v 1.19 1998/01/05 03:34:22 momjian Exp $
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/catcache.c,v 1.20 1998/01/07 21:06:08 momjian Exp $
|
||||
*
|
||||
* Notes:
|
||||
* XXX This needs to use exception.h to handle recovery when
|
||||
@ -568,7 +568,7 @@ ResetSystemCache()
|
||||
CACHE1_elog(DEBUG, "ResetSystemCache called");
|
||||
if (DisableCache)
|
||||
{
|
||||
elog(ABORT, "ResetSystemCache: Called while cache disabled");
|
||||
elog(ERROR, "ResetSystemCache: Called while cache disabled");
|
||||
return;
|
||||
}
|
||||
|
||||
@ -605,7 +605,7 @@ ResetSystemCache()
|
||||
nextelt = DLGetSucc(elt);
|
||||
CatCacheRemoveCTup(cache, elt);
|
||||
if (cache->cc_ntup == -1)
|
||||
elog(ABORT, "ResetSystemCache: cc_ntup<0 (software error)");
|
||||
elog(ERROR, "ResetSystemCache: cc_ntup<0 (software error)");
|
||||
}
|
||||
}
|
||||
cache->cc_ntup = 0; /* in case of WARN error above */
|
||||
@ -892,7 +892,7 @@ SearchSysCache(struct catcache * cache,
|
||||
|
||||
if (DisableCache)
|
||||
{
|
||||
elog(ABORT, "SearchSysCache: Called while cache disabled");
|
||||
elog(ERROR, "SearchSysCache: Called while cache disabled");
|
||||
return ((HeapTuple) NULL);
|
||||
}
|
||||
|
||||
|
12
src/backend/utils/cache/fcache.c
vendored
12
src/backend/utils/cache/fcache.c
vendored
@ -7,7 +7,7 @@
|
||||
*
|
||||
*
|
||||
* IDENTIFICATION
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/Attic/fcache.c,v 1.8 1998/01/05 03:34:24 momjian Exp $
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/Attic/fcache.c,v 1.9 1998/01/07 21:06:11 momjian Exp $
|
||||
*
|
||||
*-------------------------------------------------------------------------
|
||||
*/
|
||||
@ -71,7 +71,7 @@ GetDynamicFuncArgType(Var *arg, ExprContext *econtext)
|
||||
tup = SearchSysCacheTuple(TYPNAME, PointerGetDatum(relname),
|
||||
0, 0, 0);
|
||||
if (!tup)
|
||||
elog(ABORT, "Lookup failed on type tuple for class %s",
|
||||
elog(ERROR, "Lookup failed on type tuple for class %s",
|
||||
relname);
|
||||
|
||||
return tup->t_oid;
|
||||
@ -100,14 +100,14 @@ init_fcache(Oid foid,
|
||||
retval = (FunctionCachePtr) palloc(sizeof(FunctionCache));
|
||||
|
||||
if (!use_syscache)
|
||||
elog(ABORT, "what the ????, init the fcache without the catalogs?");
|
||||
elog(ERROR, "what the ????, init the fcache without the catalogs?");
|
||||
|
||||
procedureTuple = SearchSysCacheTuple(PROOID,
|
||||
ObjectIdGetDatum(foid),
|
||||
0, 0, 0);
|
||||
|
||||
if (!HeapTupleIsValid(procedureTuple))
|
||||
elog(ABORT,
|
||||
elog(ERROR,
|
||||
"init_fcache: %s %d",
|
||||
"Cache lookup failed for procedure", foid);
|
||||
|
||||
@ -128,7 +128,7 @@ init_fcache(Oid foid,
|
||||
0, 0, 0);
|
||||
|
||||
if (!HeapTupleIsValid(typeTuple))
|
||||
elog(ABORT,
|
||||
elog(ERROR,
|
||||
"init_fcache: %s %d",
|
||||
"Cache lookup failed for type",
|
||||
(procedureStruct)->prorettype);
|
||||
@ -311,6 +311,6 @@ setFcache(Node *node, Oid foid, List *argList, ExprContext *econtext)
|
||||
}
|
||||
else
|
||||
{
|
||||
elog(ABORT, "init_fcache: node must be Oper or Func!");
|
||||
elog(ERROR, "init_fcache: node must be Oper or Func!");
|
||||
}
|
||||
}
|
||||
|
6
src/backend/utils/cache/lsyscache.c
vendored
6
src/backend/utils/cache/lsyscache.c
vendored
@ -7,7 +7,7 @@
|
||||
*
|
||||
*
|
||||
* IDENTIFICATION
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/lsyscache.c,v 1.8 1998/01/05 03:34:26 momjian Exp $
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/lsyscache.c,v 1.9 1998/01/07 21:06:12 momjian Exp $
|
||||
*
|
||||
* NOTES
|
||||
* Eventually, the index information should go through here, too.
|
||||
@ -148,7 +148,7 @@ get_attisset(Oid relid, char *attname)
|
||||
PointerGetDatum(attname),
|
||||
0, 0);
|
||||
if (!HeapTupleIsValid(htup))
|
||||
elog(ABORT, "get_attisset: no attribute %s in relation %d",
|
||||
elog(ERROR, "get_attisset: no attribute %s in relation %d",
|
||||
attname, relid);
|
||||
if (heap_attisnull(htup, attno))
|
||||
return (false);
|
||||
@ -203,7 +203,7 @@ get_opname(Oid opno)
|
||||
return (pstrdup(optup.oprname.data));
|
||||
else
|
||||
{
|
||||
elog(ABORT, "can't look up operator %d\n", opno);
|
||||
elog(ERROR, "can't look up operator %d\n", opno);
|
||||
return NULL;
|
||||
}
|
||||
}
|
||||
|
30
src/backend/utils/cache/relcache.c
vendored
30
src/backend/utils/cache/relcache.c
vendored
@ -7,7 +7,7 @@
|
||||
*
|
||||
*
|
||||
* IDENTIFICATION
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.31 1998/01/05 03:34:29 momjian Exp $
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.32 1998/01/07 21:06:13 momjian Exp $
|
||||
*
|
||||
*-------------------------------------------------------------------------
|
||||
*/
|
||||
@ -371,7 +371,7 @@ scan_pg_rel_seq(RelationBuildDescInfo buildinfo)
|
||||
break;
|
||||
|
||||
default:
|
||||
elog(ABORT, "ScanPgRelation: bad buildinfo");
|
||||
elog(ERROR, "ScanPgRelation: bad buildinfo");
|
||||
return NULL;
|
||||
}
|
||||
|
||||
@ -441,7 +441,7 @@ scan_pg_rel_ind(RelationBuildDescInfo buildinfo)
|
||||
break;
|
||||
|
||||
default:
|
||||
elog(ABORT, "ScanPgRelation: bad buildinfo");
|
||||
elog(ERROR, "ScanPgRelation: bad buildinfo");
|
||||
|
||||
/*
|
||||
* XXX I hope this is right. It seems better than returning
|
||||
@ -583,7 +583,7 @@ build_tupdesc_seq(RelationBuildDescInfo buildinfo,
|
||||
}
|
||||
|
||||
if (need > 0)
|
||||
elog(ABORT, "catalog is missing %d attribute%s for relid %d",
|
||||
elog(ERROR, "catalog is missing %d attribute%s for relid %d",
|
||||
need, (need == 1 ? "" : "s"), relation->rd_id);
|
||||
|
||||
/* ----------------
|
||||
@ -617,7 +617,7 @@ build_tupdesc_ind(RelationBuildDescInfo buildinfo,
|
||||
atttup = (HeapTuple) AttributeNumIndexScan(attrel, relation->rd_id, i);
|
||||
|
||||
if (!HeapTupleIsValid(atttup))
|
||||
elog(ABORT, "cannot find attribute %d of relation %.*s", i,
|
||||
elog(ERROR, "cannot find attribute %d of relation %.*s", i,
|
||||
NAMEDATALEN, &(relation->rd_rel->relname.data[0]));
|
||||
attp = (AttributeTupleForm) GETSTRUCT(atttup);
|
||||
|
||||
@ -1738,7 +1738,7 @@ AttrDefaultFetch(Relation relation)
|
||||
if (adform->adnum != attrdef[i].adnum)
|
||||
continue;
|
||||
if (attrdef[i].adsrc != NULL)
|
||||
elog(ABORT, "AttrDefaultFetch: second record found for attr %.*s in rel %.*s",
|
||||
elog(ERROR, "AttrDefaultFetch: second record found for attr %.*s in rel %.*s",
|
||||
NAMEDATALEN, relation->rd_att->attrs[adform->adnum - 1]->attname.data,
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
|
||||
@ -1746,7 +1746,7 @@ AttrDefaultFetch(Relation relation)
|
||||
Anum_pg_attrdef_adbin,
|
||||
adrel->rd_att, &isnull);
|
||||
if (isnull)
|
||||
elog(ABORT, "AttrDefaultFetch: adbin IS NULL for attr %.*s in rel %.*s",
|
||||
elog(ERROR, "AttrDefaultFetch: adbin IS NULL for attr %.*s in rel %.*s",
|
||||
NAMEDATALEN, relation->rd_att->attrs[adform->adnum - 1]->attname.data,
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
attrdef[i].adbin = textout(val);
|
||||
@ -1754,7 +1754,7 @@ AttrDefaultFetch(Relation relation)
|
||||
Anum_pg_attrdef_adsrc,
|
||||
adrel->rd_att, &isnull);
|
||||
if (isnull)
|
||||
elog(ABORT, "AttrDefaultFetch: adsrc IS NULL for attr %.*s in rel %.*s",
|
||||
elog(ERROR, "AttrDefaultFetch: adsrc IS NULL for attr %.*s in rel %.*s",
|
||||
NAMEDATALEN, relation->rd_att->attrs[adform->adnum - 1]->attname.data,
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
attrdef[i].adsrc = textout(val);
|
||||
@ -1762,14 +1762,14 @@ AttrDefaultFetch(Relation relation)
|
||||
}
|
||||
|
||||
if (i >= ndef)
|
||||
elog(ABORT, "AttrDefaultFetch: unexpected record found for attr %d in rel %.*s",
|
||||
elog(ERROR, "AttrDefaultFetch: unexpected record found for attr %d in rel %.*s",
|
||||
adform->adnum,
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
ReleaseBuffer(buffer);
|
||||
}
|
||||
|
||||
if (found < ndef)
|
||||
elog(ABORT, "AttrDefaultFetch: %d record not found for rel %.*s",
|
||||
elog(ERROR, "AttrDefaultFetch: %d record not found for rel %.*s",
|
||||
ndef - found,
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
|
||||
@ -1821,28 +1821,28 @@ RelCheckFetch(Relation relation)
|
||||
if (!HeapTupleIsValid(tuple))
|
||||
continue;
|
||||
if (found == ncheck)
|
||||
elog(ABORT, "RelCheckFetch: unexpected record found for rel %.*s",
|
||||
elog(ERROR, "RelCheckFetch: unexpected record found for rel %.*s",
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
|
||||
rcname = (Name) fastgetattr(tuple,
|
||||
Anum_pg_relcheck_rcname,
|
||||
rcrel->rd_att, &isnull);
|
||||
if (isnull)
|
||||
elog(ABORT, "RelCheckFetch: rcname IS NULL for rel %.*s",
|
||||
elog(ERROR, "RelCheckFetch: rcname IS NULL for rel %.*s",
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
check[found].ccname = nameout(rcname);
|
||||
val = (struct varlena *) fastgetattr(tuple,
|
||||
Anum_pg_relcheck_rcbin,
|
||||
rcrel->rd_att, &isnull);
|
||||
if (isnull)
|
||||
elog(ABORT, "RelCheckFetch: rcbin IS NULL for rel %.*s",
|
||||
elog(ERROR, "RelCheckFetch: rcbin IS NULL for rel %.*s",
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
check[found].ccbin = textout(val);
|
||||
val = (struct varlena *) fastgetattr(tuple,
|
||||
Anum_pg_relcheck_rcsrc,
|
||||
rcrel->rd_att, &isnull);
|
||||
if (isnull)
|
||||
elog(ABORT, "RelCheckFetch: rcsrc IS NULL for rel %.*s",
|
||||
elog(ERROR, "RelCheckFetch: rcsrc IS NULL for rel %.*s",
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
check[found].ccsrc = textout(val);
|
||||
found++;
|
||||
@ -1851,7 +1851,7 @@ RelCheckFetch(Relation relation)
|
||||
}
|
||||
|
||||
if (found < ncheck)
|
||||
elog(ABORT, "RelCheckFetch: %d record not found for rel %.*s",
|
||||
elog(ERROR, "RelCheckFetch: %d record not found for rel %.*s",
|
||||
ncheck - found,
|
||||
NAMEDATALEN, relation->rd_rel->relname.data);
|
||||
|
||||
|
12
src/backend/utils/cache/syscache.c
vendored
12
src/backend/utils/cache/syscache.c
vendored
@ -7,7 +7,7 @@
|
||||
*
|
||||
*
|
||||
* IDENTIFICATION
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/syscache.c,v 1.11 1998/01/05 03:34:32 momjian Exp $
|
||||
* $Header: /cvsroot/pgsql/src/backend/utils/cache/syscache.c,v 1.12 1998/01/07 21:06:15 momjian Exp $
|
||||
*
|
||||
* NOTES
|
||||
* These routines allow the parser/planner/executor to perform
|
||||
@ -371,7 +371,7 @@ InitCatalogCache()
|
||||
cacheinfo[cacheId].iScanFunc);
|
||||
if (!PointerIsValid((char *) SysCache[cacheId]))
|
||||
{
|
||||
elog(ABORT,
|
||||
elog(ERROR,
|
||||
"InitCatalogCache: Can't init cache %.16s(%d)",
|
||||
cacheinfo[cacheId].name,
|
||||
cacheId);
|
||||
@ -402,7 +402,7 @@ SearchSysCacheTuple(int cacheId, /* cache selection code */
|
||||
|
||||
if (cacheId < 0 || cacheId >= SysCacheSize)
|
||||
{
|
||||
elog(ABORT, "SearchSysCacheTuple: Bad cache id %d", cacheId);
|
||||
elog(ERROR, "SearchSysCacheTuple: Bad cache id %d", cacheId);
|
||||
return ((HeapTuple) NULL);
|
||||
}
|
||||
|
||||
@ -423,7 +423,7 @@ SearchSysCacheTuple(int cacheId, /* cache selection code */
|
||||
cacheinfo[cacheId].iScanFunc);
|
||||
if (!PointerIsValid(SysCache[cacheId]))
|
||||
{
|
||||
elog(ABORT,
|
||||
elog(ERROR,
|
||||
"InitCatalogCache: Can't init cache %.16s(%d)",
|
||||
cacheinfo[cacheId].name,
|
||||
cacheId);
|
||||
@ -469,7 +469,7 @@ SearchSysCacheStruct(int cacheId, /* cache selection code */
|
||||
|
||||
if (!PointerIsValid(returnStruct))
|
||||
{
|
||||
elog(ABORT, "SearchSysCacheStruct: No receiving struct");
|
||||
elog(ERROR, "SearchSysCacheStruct: No receiving struct");
|
||||
return (0);
|
||||
}
|
||||
tp = SearchSysCacheTuple(cacheId, key1, key2, key3, key4);
|
||||
@ -537,7 +537,7 @@ SearchSysCacheGetAttribute(int cacheId,
|
||||
}
|
||||
else
|
||||
{
|
||||
elog(ABORT,
|
||||
elog(ERROR,
|
||||
"SearchSysCacheGetAttribute: Bad attr # %d in %s(%d)",
|
||||
attributeNumber, cacheName, cacheId);
|
||||
return (NULL);
|
||||
|
Reference in New Issue
Block a user