database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-11 05:41:32 +03:00
Code

Don't set BootstrapProcessingMode in AddNewRelationTuple() before

Browse Source 
heap_insert() any more. No reasons to do it, and old comments
said about this.
This commit is contained in:
Vadim B. Mikheev 1999-10-06 03:08:46 +00:00
parent 56ba75cb53
commit 66fbea5041
1 changed files with 4 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/catalog/heap.c
View File

@ -7,7 +7,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.101 1999/10/04 02:12:26 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.102 1999/10/06 03:08:46 vadim Exp $
* *
* *
* INTERFACE ROUTINES * INTERFACE ROUTINES
@ -642,7 +642,6 @@ AddNewRelationTuple(Relation pg_class_desc,
Form_pg_class new_rel_reltup; Form_pg_class new_rel_reltup;
HeapTuple tup; HeapTuple tup;
Relation idescs[Num_pg_class_indices]; Relation idescs[Num_pg_class_indices];
bool isBootstrap;
/* ---------------- /* ----------------
* first we munge some of the information in our * first we munge some of the information in our
@ -689,36 +688,23 @@ AddNewRelationTuple(Relation pg_class_desc,
(char *) new_rel_reltup); (char *) new_rel_reltup);
tup->t_data->t_oid = new_rel_oid; tup->t_data->t_oid = new_rel_oid;
/* ---------------- /*
* finally insert the new tuple and free it. * finally insert the new tuple and free it.
*
* Note: I have no idea why we do a
* SetProcessingMode(BootstrapProcessing);
* here -cim 6/14/90
* ----------------
*/ */
isBootstrap = IsBootstrapProcessingMode() ? true : false;
SetProcessingMode(BootstrapProcessing);
heap_insert(pg_class_desc, tup); heap_insert(pg_class_desc, tup);
if (temp_relname) if (temp_relname)
create_temp_relation(temp_relname, tup); create_temp_relation(temp_relname, tup);
if (!isBootstrap) if (!IsBootstrapProcessingMode())
{ {
/* /*
* First, open the catalog indices and insert index tuples for the * First, open the catalog indices and insert index tuples for the
* new relation. * new relation.
*/ */
CatalogOpenIndices(Num_pg_class_indices, Name_pg_class_indices, idescs); CatalogOpenIndices(Num_pg_class_indices, Name_pg_class_indices, idescs);
CatalogIndexInsert(idescs, Num_pg_class_indices, pg_class_desc, tup); CatalogIndexInsert(idescs, Num_pg_class_indices, pg_class_desc, tup);
CatalogCloseIndices(Num_pg_class_indices, idescs); CatalogCloseIndices(Num_pg_class_indices, idescs);
/* now restore processing mode */
SetProcessingMode(NormalProcessing);
} }
pfree(tup); pfree(tup);