database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-18 05:01:01 +03:00
Code Activity

Make "pgoff_t" be a typedef not a #define.

Browse Source 
There doesn't seem to be any great reason why this has been a macro
rather than a typedef.  But doing it like that means our buildfarm
typedef tooling doesn't capture the name as a typedef.  That would
result in pgindent glitches, except that we've seemingly kept it
in typedefs.list manually.  That's obviously error-prone, so let's
convert it to a typedef now.

Discussion: https://postgr.es/m/1681301.1765742268@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2025-12-14 16:53:34 -05:00
parent fe7ede45f1
commit 66b2282b0c
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/include/port.h
View File

@@ -418,7 +418,7 @@ extern FILE *pgwin32_popen(const char *command, const char *type);
/* Type to use with fseeko/ftello */ /* Type to use with fseeko/ftello */
#ifndef WIN32 /* WIN32 is handled in port/win32_port.h */ #ifndef WIN32 /* WIN32 is handled in port/win32_port.h */
#define pgoff_t off_t typedef off_t pgoff_t;
#endif #endif
#ifndef HAVE_GETPEEREID #ifndef HAVE_GETPEEREID

2
src/include/port/win32_port.h
View File

@@ -194,7 +194,7 @@ extern DWORD pgwin32_get_file_type(HANDLE hFile);
* with 64-bit offsets. Also, fseek() might not give an error for unseekable * with 64-bit offsets. Also, fseek() might not give an error for unseekable
* streams, so harden that function with our version. * streams, so harden that function with our version.
*/ */
#define pgoff_t __int64 typedef __int64 pgoff_t;
#ifdef _MSC_VER #ifdef _MSC_VER
extern int _pgfseeko64(FILE *stream, pgoff_t offset, int origin); extern int _pgfseeko64(FILE *stream, pgoff_t offset, int origin);