database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-12 21:01:52 +03:00
Code Activity

Fix comment in regression tests for large objects

Browse Source 
The values assigned to INV_WRITE and INV_READ were reversed in the
tests, which would be confusing when writing tests specific to read or
write operations on LOs.

Author: Yugo Nagata
Discussion: https://postgr.es/m/20220527153028.61a4608f66abcd026fd3806f@sraoss.co.jp
This commit is contained in:
Michael Paquier
2022-06-16 17:21:04 +09:00
parent b7658c24c7
commit 664da2a389
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/regress/expected/largeobject.out
View File

@ -50,8 +50,8 @@ INSERT INTO lotest_stash_values (loid) SELECT lo_creat(42);
BEGIN; BEGIN;
-- lo_open(lobjId oid, mode integer) returns integer -- lo_open(lobjId oid, mode integer) returns integer
-- The mode parameter to lo_open uses two constants: -- The mode parameter to lo_open uses two constants:
-- INV_READ = 0x20000 -- INV_WRITE = 0x20000
-- INV_WRITE = 0x40000 -- INV_READ = 0x40000
-- The return value is a file descriptor-like value which remains valid for the -- The return value is a file descriptor-like value which remains valid for the
-- transaction. -- transaction.
UPDATE lotest_stash_values SET fd = lo_open(loid, CAST(x'20000' | x'40000' AS integer)); UPDATE lotest_stash_values SET fd = lo_open(loid, CAST(x'20000' | x'40000' AS integer));

4
src/test/regress/expected/largeobject_1.out
View File

@ -50,8 +50,8 @@ INSERT INTO lotest_stash_values (loid) SELECT lo_creat(42);
BEGIN; BEGIN;
-- lo_open(lobjId oid, mode integer) returns integer -- lo_open(lobjId oid, mode integer) returns integer
-- The mode parameter to lo_open uses two constants: -- The mode parameter to lo_open uses two constants:
-- INV_READ = 0x20000 -- INV_WRITE = 0x20000
-- INV_WRITE = 0x40000 -- INV_READ = 0x40000
-- The return value is a file descriptor-like value which remains valid for the -- The return value is a file descriptor-like value which remains valid for the
-- transaction. -- transaction.
UPDATE lotest_stash_values SET fd = lo_open(loid, CAST(x'20000' | x'40000' AS integer)); UPDATE lotest_stash_values SET fd = lo_open(loid, CAST(x'20000' | x'40000' AS integer));

4
src/test/regress/sql/largeobject.sql
View File

@ -34,8 +34,8 @@ BEGIN;
-- lo_open(lobjId oid, mode integer) returns integer -- lo_open(lobjId oid, mode integer) returns integer
-- The mode parameter to lo_open uses two constants: -- The mode parameter to lo_open uses two constants:
-- INV_READ = 0x20000 -- INV_WRITE = 0x20000
-- INV_WRITE = 0x40000 -- INV_READ = 0x40000
-- The return value is a file descriptor-like value which remains valid for the -- The return value is a file descriptor-like value which remains valid for the
-- transaction. -- transaction.
UPDATE lotest_stash_values SET fd = lo_open(loid, CAST(x'20000' | x'40000' AS integer)); UPDATE lotest_stash_values SET fd = lo_open(loid, CAST(x'20000' | x'40000' AS integer));