database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-26 01:22:12 +03:00
Code Activity

Revert "Add recovery TAP test for race condition with slot invalidations"

Browse Source 
This reverts commit 08a52ab151, due to some sporadic instability in
the test.  Getting the test right should require some redesign with a
second injection point, but let's revert it for now to avoid these
issues in the CI as a lot of patches are under discussion in this last
commit fest.

Per buildfarm members hachi and gokiburi.

Discussion: https://postgr.es/m/ZekQQHCrIqLVpGz5@paquier.xyz
This commit is contained in:
Michael Paquier
2024-03-07 09:57:52 +09:00
parent 099ca50bd4
commit 65db0cfb4c
2 changed files with 2 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/replication/slot.c
View File

@ -53,7 +53,6 @@
#include "storage/proc.h"
#include "storage/procarray.h"
#include "utils/builtins.h"
#include "utils/injection_point.h"
/*
* Replication slot on-disk data structure.
@ -1659,14 +1658,6 @@ InvalidatePossiblyObsoleteSlot(ReplicationSlotInvalidationCause cause,
last_signaled_pid = active_pid;
terminated = true;
conflict_prev = conflict;
/*
* This injection point needs to be after kill() to ensure
* that the slot is not "active" anymore. It also has to be
* after ReportSlotInvalidation() to ensure that the
* invalidation message is logged.
*/
INJECTION_POINT("terminate-process-holding-slot");
}
/* Wait until the slot is released. */