database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-02 04:21:28 +03:00
Code Activity

Suppress "unused variable" warnings with older versions of flex.

Browse Source 
Versions of flex before 2.5.36 might generate code that results in an
"unused variable" warning, when using %option reentrant.  Historically
we've worked around that by specifying -Wno-error, but that's an
unsatisfying solution.  The official "fix" for this was just to insert a
dummy reference to the variable, so write a small perl script that edits
the generated C code similarly.

The MSVC side of this is untested, but the buildfarm should soon reveal
if I broke that.

Discussion: https://postgr.es/m/25456.1487437842@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2017-02-19 13:04:30 -05:00
parent a3dc8e495b
commit 65d508fd4d
6 changed files with 82 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/fe_utils/Makefile
View File

@@ -29,11 +29,7 @@ libpgfeutils.a: $(OBJS)
psqlscan.c: FLEXFLAGS = -Cfe -p -p
psqlscan.c: FLEX_NO_BACKUP=yes
# Latest flex causes warnings in this file.
ifeq ($(GCC),yes)
psqlscan.o: CFLAGS += -Wno-error
endif
psqlscan.c: FLEX_FIX_WARNING=yes
distprep: psqlscan.c