database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-24 10:47:04 +03:00
Code

Make a no-op ALTER EXTENSION UPDATE give just a NOTICE, not ERROR.

Browse Source 
This seems a bit more user-friendly.
This commit is contained in:
Tom Lane 2011-02-16 12:39:45 -05:00
parent b4a7e5980b
commit 65076269ea
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/commands/extension.c
View File

@ -1035,11 +1035,6 @@ identify_update_path(ExtensionControlFile *control,
ExtensionVersionInfo *evi_start;
ExtensionVersionInfo *evi_target;
if (strcmp(oldVersion, newVersion) == 0)
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("version to install or update to must be different from old version")));
/* Extract the version update graph from the script directory */
evi_list = get_ext_ver_list(control);
@ -1262,6 +1257,12 @@ CreateExtension(CreateExtensionStmt *stmt)
oldVersionName = strVal(d_old_version->arg);
check_valid_version_name(oldVersionName);
if (strcmp(oldVersionName, versionName) == 0)
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("FROM version must be different from installation target version \"%s\"",
versionName)));
updateVersions = identify_update_path(pcontrol,
oldVersionName,
versionName);
@ -2464,6 +2465,17 @@ ExecAlterExtensionStmt(AlterExtensionStmt *stmt)
}
check_valid_version_name(versionName);
/*
* If we're already at that version, just say so
*/
if (strcmp(oldVersionName, versionName) == 0)
{
ereport(NOTICE,
(errmsg("version \"%s\" of extension \"%s\" is already installed",
versionName, stmt->extname)));
return;
}
/*
* Identify the series of update script files we need to execute
*/