database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-11 04:22:52 +03:00
Code Activity

pgbench: Fix overflow in table populating when rows >= 2^31-1

Browse Source 
Using a scale factor large enough so as the number of rows to insert
gets larger than INT32_MAX would cause an infinite loop in
initPopulateTable(), preventing pgbench to finish its initialization.

Oversight in e35cc3b3f2 that has refactored the data generation logic.

Author: John Hsu
Reviewed-by: Tatsuo Ishii, Japin Li
Discussion: https://postgr.es/m/CA+-JvFvHsOafjHcuFPfkyouHNZvbOXhBNhwZxKm3WNgYz9bwzA@mail.gmail.com
This commit is contained in:
Michael Paquier
2023-12-24 11:49:14 +09:00
parent da44ff312e
commit 64e77b496a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/pgbench/pgbench.c
View File

@@ -4908,7 +4908,7 @@ initPopulateTable(PGconn *con, const char *table, int64 base,
initRowMethod init_row) initRowMethod init_row)
{ {
int n; int n;
int k; int64 k;
int chars = 0; int chars = 0;
PGresult *res; PGresult *res;
PQExpBufferData sql; PQExpBufferData sql;