Code review for standalone composite types, query-specified composite

types, SRFs.  Not happy with memory management yet, but I'll commit these
other changes.

src/include/funcapi.h

@@ -9,26 +9,18 @@
  *
  * Copyright (c) 2002, PostgreSQL Global Development Group
  *
+ * $Id: funcapi.h,v 1.5 2002/08/29 00:17:06 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
 #ifndef FUNCAPI_H
 #define FUNCAPI_H
 
-#include "postgres.h"
-
 #include "fmgr.h"
-#include "access/htup.h"
 #include "access/tupdesc.h"
 #include "executor/executor.h"
 #include "executor/tuptable.h"
 
-/*
- * All functions that can be called directly by fmgr must have this signature.
- * (Other functions can be called by using a handler that does have this
- * signature.)
- */
-
 
 /*-------------------------------------------------------------------------
  *	Support to ease writing Functions returning composite types
@@ -40,20 +32,19 @@
  * is derived from the TupleDesc, but it is stored here to
  * avoid redundant cpu cycles on each call to an SRF.
  */
-typedef struct
+typedef struct AttInMetadata
 {
 	/* full TupleDesc */
 	TupleDesc	   tupdesc;
 
-	/* pointer to array of attribute "type"in finfo */
+	/* array of attribute type input function finfo */
 	FmgrInfo	   *attinfuncs;
 
-	/* pointer to array of attribute type typelem */
+	/* array of attribute type typelem */
 	Oid			   *attelems;
 
-	/* pointer to array of attribute type typtypmod */
-	int4		   *atttypmods;
-
+	/* array of attribute typmod */
+	int32		   *atttypmods;
 }	AttInMetadata;
 
 /*-------------------------------------------------------------------------
@@ -63,7 +54,7 @@ typedef struct
  * This struct holds function context for Set Returning Functions.
  * Use fn_extra to hold a pointer to it across calls
  */
-typedef struct
+typedef struct FuncCallContext
 {
 	/*
 	 * Number of times we've been called before.
@@ -120,35 +111,34 @@ typedef struct
 
 }	FuncCallContext;
 
-/*-------------------------------------------------------------------------
+/*----------
  *	Support to ease writing Functions returning composite types
  *
  * External declarations:
- * TupleDesc RelationNameGetTupleDesc(char *relname) - Use to get a TupleDesc
- *		based on the function's return type relation.
+ * TupleDesc RelationNameGetTupleDesc(const char *relname) - Use to get a
+ *		TupleDesc based on a specified relation.
  * TupleDesc TypeGetTupleDesc(Oid typeoid, List *colaliases) - Use to get a
- *		TupleDesc based on the function's type oid. This can be used to get
- *		a TupleDesc for a base (scalar), or composite (relation) type.
+ *		TupleDesc based on a type OID. This can be used to get
+ *		a TupleDesc for a base (scalar) or composite (relation) type.
  * TupleTableSlot *TupleDescGetSlot(TupleDesc tupdesc) - Initialize a slot
  *		given a TupleDesc.
- * AttInMetadata *TupleDescGetAttInMetadata(TupleDesc tupdesc) - Get a pointer
- *		to AttInMetadata based on the function's TupleDesc. AttInMetadata can
+ * AttInMetadata *TupleDescGetAttInMetadata(TupleDesc tupdesc) - Build an
+ *		AttInMetadata struct based on the given TupleDesc. AttInMetadata can
  *		be used in conjunction with C strings to produce a properly formed
  *		tuple. Store the metadata here for use across calls to avoid redundant
  *		work.
  * HeapTuple BuildTupleFromCStrings(AttInMetadata *attinmeta, char **values) -
  *		build a HeapTuple given user data in C string form. values is an array
  *		of C strings, one for each attribute of the return tuple.
- * void get_type_metadata(Oid typeid, Oid *attinfuncid, Oid *attelem) - Get
- *      an attribute "in" function and typelem value given the typeid.
  *
  * Macro declarations:
  * TupleGetDatum(TupleTableSlot *slot, HeapTuple tuple) - get a Datum
  *		given a tuple and a slot.
+ *----------
  */
 
 /* from tupdesc.c */
-extern TupleDesc RelationNameGetTupleDesc(char *relname);
+extern TupleDesc RelationNameGetTupleDesc(const char *relname);
 extern TupleDesc TypeGetTupleDesc(Oid typeoid, List *colaliases);
 
 /* from execTuples.c */
@@ -156,13 +146,11 @@ extern TupleTableSlot *TupleDescGetSlot(TupleDesc tupdesc);
 extern AttInMetadata *TupleDescGetAttInMetadata(TupleDesc tupdesc);
 extern HeapTuple BuildTupleFromCStrings(AttInMetadata *attinmeta, char **values);
 
-/* from funcapi.c */
-extern void get_type_metadata(Oid typeid, Oid *attinfuncid, Oid *attelem);
-
 #define TupleGetDatum(_slot, _tuple) \
 	PointerGetDatum(ExecStoreTuple(_tuple, _slot, InvalidBuffer, true))
 
-/*-------------------------------------------------------------------------
+
+/*----------
  *		Support for Set Returning Functions (SRFs)
  *
  * The basic API for SRFs looks something like:
@@ -200,6 +188,7 @@ extern void get_type_metadata(Oid typeid, Oid *attinfuncid, Oid *attelem);
  * 	}
  * }
  *
+ *----------
  */
 
 /* from funcapi.c */
@@ -208,12 +197,15 @@ extern FuncCallContext *per_MultiFuncCall(PG_FUNCTION_ARGS);
 extern void end_MultiFuncCall(PG_FUNCTION_ARGS, FuncCallContext *funcctx);
 
 #define SRF_IS_FIRSTCALL() (fcinfo->flinfo->fn_extra == NULL)
+
 #define SRF_FIRSTCALL_INIT() init_MultiFuncCall(fcinfo)
+
 #define SRF_PERCALL_SETUP() per_MultiFuncCall(fcinfo)
+
 #define SRF_RETURN_NEXT(_funcctx, _result) \
 	do { \
 		ReturnSetInfo	   *rsi; \
-		_funcctx->call_cntr++; \
+		(_funcctx)->call_cntr++; \
 		rsi = (ReturnSetInfo *) fcinfo->resultinfo; \
 		rsi->isDone = ExprMultipleResult; \
 		PG_RETURN_DATUM(_result); \
@@ -225,7 +217,6 @@ extern void end_MultiFuncCall(PG_FUNCTION_ARGS, FuncCallContext *funcctx);
 		end_MultiFuncCall(fcinfo, _funcctx); \
 		rsi = (ReturnSetInfo *) fcinfo->resultinfo; \
 		rsi->isDone = ExprEndResult; \
-		_funcctx->slot = NULL; \
 		PG_RETURN_NULL(); \
 	} while (0)