database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Use Enum for top level logical replication message types.

Browse Source 
Logical replication protocol uses a single byte character to identify a
message type in logical replication protocol. The code uses string
literals for the same. Use Enum so that

1. All the string literals used can be found at a single place. This
makes it easy to add more types without the risk of conflicts.

2. It's easy to locate the code handling a given message type.

3. When used with switch statements, it is easy to identify the missing
cases using -Wswitch.

Author: Ashutosh Bapat
Reviewed-by: Kyotaro Horiguchi, Andres Freund, Peter Smith and Amit Kapila
Discussion: https://postgr.es/m/CAExHW5uPzQ7L0oAd_ENyvaiYMOPgkrAoJpE+ZY5-obdcVT6NPg@mail.gmail.com
This commit is contained in:
Amit Kapila
2020-11-02 08:18:18 +05:30
parent a929e17e5a
commit 644f0d7cc9
3 changed files with 83 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

87
src/backend/replication/logical/worker.c
View File

@ -1896,67 +1896,66 @@ apply_handle_truncate(StringInfo s)
static void
apply_dispatch(StringInfo s)
{
char action = pq_getmsgbyte(s);
LogicalRepMsgType action = pq_getmsgbyte(s);
switch (action)
{
/* BEGIN */
case 'B':
case LOGICAL_REP_MSG_BEGIN:
apply_handle_begin(s);
break;
/* COMMIT */
case 'C':
return;
case LOGICAL_REP_MSG_COMMIT:
apply_handle_commit(s);
break;
/* INSERT */
case 'I':
return;
case LOGICAL_REP_MSG_INSERT:
apply_handle_insert(s);
break;
/* UPDATE */
case 'U':
return;
case LOGICAL_REP_MSG_UPDATE:
apply_handle_update(s);
break;
/* DELETE */
case 'D':
return;
case LOGICAL_REP_MSG_DELETE:
apply_handle_delete(s);
break;
/* TRUNCATE */
case 'T':
return;
case LOGICAL_REP_MSG_TRUNCATE:
apply_handle_truncate(s);
break;
/* RELATION */
case 'R':
return;
case LOGICAL_REP_MSG_RELATION:
apply_handle_relation(s);
break;
/* TYPE */
case 'Y':
return;
case LOGICAL_REP_MSG_TYPE:
apply_handle_type(s);
break;
/* ORIGIN */
case 'O':
return;
case LOGICAL_REP_MSG_ORIGIN:
apply_handle_origin(s);
break;
/* STREAM START */
case 'S':
return;
case LOGICAL_REP_MSG_STREAM_START:
apply_handle_stream_start(s);
break;
/* STREAM END */
case 'E':
return;
case LOGICAL_REP_MSG_STREAM_END:
apply_handle_stream_stop(s);
break;
/* STREAM ABORT */
case 'A':
return;
case LOGICAL_REP_MSG_STREAM_ABORT:
apply_handle_stream_abort(s);
break;
/* STREAM COMMIT */
case 'c':
return;
case LOGICAL_REP_MSG_STREAM_COMMIT:
apply_handle_stream_commit(s);
break;
default:
ereport(ERROR,
(errcode(ERRCODE_PROTOCOL_VIOLATION),
errmsg("invalid logical replication message type \"%c\"", action)));
return;
}
ereport(ERROR,
(errcode(ERRCODE_PROTOCOL_VIOLATION),
errmsg("invalid logical replication message type \"%c\"", action)));
}
/*