database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-26 12:21:12 +03:00
Code Activity

Rename logical_replication_mode to debug_logical_replication_streaming

Browse Source 
The logical_replication_mode GUC is intended for testing and debugging
purposes, but its current name may be misleading and encourage users to make
unnecessary changes.

To avoid confusion, renaming the GUC to a less misleading name
debug_logical_replication_streaming that casual users are less likely to mistakenly
assume needs to be modified in a regular logical replication setup.

Author: Hou Zhijie <houzj.fnst@cn.fujitsu.com>
Reviewed-by: Peter Smith <smithpb2250@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/d672d774-c44b-6fec-f993-793e744f169a%40eisentraut.org
This commit is contained in:
Peter Eisentraut
2023-08-29 15:15:54 +02:00
parent f347ec76e2
commit 63956bed7b
10 changed files with 41 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/utils/misc/guc_tables.c
View File

@ -420,9 +420,9 @@ static const struct config_enum_entry ssl_protocol_versions_info[] = {
{NULL, 0, false}
};
static const struct config_enum_entry logical_replication_mode_options[] = {
{"buffered", LOGICAL_REP_MODE_BUFFERED, false},
{"immediate", LOGICAL_REP_MODE_IMMEDIATE, false},
static const struct config_enum_entry debug_logical_replication_streaming_options[] = {
{"buffered", DEBUG_LOGICAL_REP_STREAMING_BUFFERED, false},
{"immediate", DEBUG_LOGICAL_REP_STREAMING_IMMEDIATE, false},
{NULL, 0, false}
};
@ -4969,15 +4969,15 @@ struct config_enum ConfigureNamesEnum[] =
},
{
{"logical_replication_mode", PGC_USERSET, DEVELOPER_OPTIONS,
gettext_noop("Controls when to replicate or apply each change."),
{"debug_logical_replication_streaming", PGC_USERSET, DEVELOPER_OPTIONS,
gettext_noop("Forces immediate streaming or serialization of changes in large transactions."),
gettext_noop("On the publisher, it allows streaming or serializing each change in logical decoding. "
"On the subscriber, it allows serialization of all changes to files and notifies the "
"parallel apply workers to read and apply them at the end of the transaction."),
GUC_NOT_IN_SAMPLE
},
&logical_replication_mode,
LOGICAL_REP_MODE_BUFFERED, logical_replication_mode_options,
&debug_logical_replication_streaming,
DEBUG_LOGICAL_REP_STREAMING_BUFFERED, debug_logical_replication_streaming_options,
NULL, NULL, NULL
},