database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Fix incorrect logic in plan dependency recording

Browse Source 
Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency
on a function but mistakenly inverted the OidIsValid test.  This meant
that we'd record a dependency only when the function's Oid was
InvalidOid.  Clearly this was meant to *not* record the dependency in
that case.

50e17ad28 made this mistake first, then in v15 29f45e299 copied the same
mistake.

Reported-by: Tom Lane
Backpatch-through: 14, where 50e17ad28 first made this mistake
Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us
This commit is contained in:
David Rowley
2023-09-14 11:27:43 +12:00
parent e2452c2a63
commit 6341cb0b02
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/optimizer/plan/setrefs.c
View File

@@ -1775,7 +1775,7 @@ fix_expr_common(PlannerInfo *root, Node *node)
set_sa_opfuncid(saop); set_sa_opfuncid(saop);
record_plan_function_dependency(root, saop->opfuncid); record_plan_function_dependency(root, saop->opfuncid);
if (!OidIsValid(saop->hashfuncid)) if (OidIsValid(saop->hashfuncid))
record_plan_function_dependency(root, saop->hashfuncid); record_plan_function_dependency(root, saop->hashfuncid);
} }
else if (IsA(node, Const)) else if (IsA(node, Const))