database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-07 12:02:30 +03:00
Code Activity

Remove useless casts to Pointer

Browse Source 
in arguments of memcpy() and memmove() calls

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://www.postgresql.org/message-id/4154950a-47ae-4223-bd01-1235cc50e933%40eisentraut.org
This commit is contained in:
Peter Eisentraut
2025-12-03 08:40:33 +01:00
parent c252d37d8c
commit 623801b3bd
4 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/bloom/blutils.c
View File

@@ -336,7 +336,7 @@ BloomPageAddItem(BloomState *state, Page page, BloomTuple *tuple)
/* Copy new tuple to the end of page */ /* Copy new tuple to the end of page */
opaque = BloomPageGetOpaque(page); opaque = BloomPageGetOpaque(page);
itup = BloomPageGetTuple(state, page, opaque->maxoff + 1); itup = BloomPageGetTuple(state, page, opaque->maxoff + 1);
memcpy((Pointer) itup, (Pointer) tuple, state->sizeOfBloomTuple); memcpy(itup, tuple, state->sizeOfBloomTuple);
/* Adjust maxoff and pd_lower */ /* Adjust maxoff and pd_lower */
opaque->maxoff++; opaque->maxoff++;

3
contrib/bloom/blvacuum.c
View File

@@ -94,8 +94,7 @@ blbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
{ {
/* No; copy it to itupPtr++, but skip copy if not needed */ /* No; copy it to itupPtr++, but skip copy if not needed */
if (itupPtr != itup) if (itupPtr != itup)
memmove((Pointer) itupPtr, (Pointer) itup, memmove(itupPtr, itup, state.sizeOfBloomTuple);
state.sizeOfBloomTuple);
itupPtr = BloomPageGetNextTuple(&state, itupPtr); itupPtr = BloomPageGetNextTuple(&state, itupPtr);
} }

2
src/backend/access/gin/ginxlog.c
View File

@@ -212,7 +212,7 @@ ginRedoRecompress(Page page, ginxlogRecompressDataLeaf *data)
if (tailCopy) if (tailCopy)
{ {
Assert(writePtr + segsize < PageGetSpecialPointer(page)); Assert(writePtr + segsize < PageGetSpecialPointer(page));
memcpy(writePtr, (Pointer) oldseg, segsize); memcpy(writePtr, oldseg, segsize);
} }
writePtr += segsize; writePtr += segsize;
oldseg = GinNextPostingListSegment(oldseg); oldseg = GinNextPostingListSegment(oldseg);

2
src/backend/utils/adt/multirangetypes.c
View File

@@ -629,7 +629,7 @@ write_multirange_data(MultirangeType *multirange, TypeCacheEntry *rangetyp,
} }
flags[i] = *((Pointer) ranges[i] + VARSIZE(ranges[i]) - sizeof(char)); flags[i] = *((Pointer) ranges[i] + VARSIZE(ranges[i]) - sizeof(char));
len = VARSIZE(ranges[i]) - sizeof(RangeType) - sizeof(char); len = VARSIZE(ranges[i]) - sizeof(RangeType) - sizeof(char);
memcpy(ptr, (Pointer) (ranges[i] + 1), len); memcpy(ptr, ranges[i] + 1, len);
ptr += att_align_nominal(len, elemalign); ptr += att_align_nominal(len, elemalign);
} }
} }