mirror of
https://github.com/postgres/postgres.git
synced 2025-12-19 17:02:53 +03:00
ci: Add missing "set -e" to scripts run by su.
If any shell command fails, the whole script should fail. To avoid future omissions, add this even for single-command scripts that use su with heredoc syntax, as they might be extended or copied-and-pasted. Extracted from a larger patch that wanted to use #error during compilation, leading to the diagnosis of this problem. Reviewed-by: Tristan Partin <tristan@partin.io> (earlier version) Discussion: https://postgr.es/m/DDZP25P4VZ48.3LWMZBGA1K9RH%40partin.io Backpatch-through: 15
This commit is contained in:
@@ -94,6 +94,7 @@ task:
|
||||
|
||||
configure_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
meson setup \
|
||||
--buildtype=debug \
|
||||
--auto-features=disabled \
|
||||
@@ -102,6 +103,7 @@ task:
|
||||
EOF
|
||||
build_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
ninja -C build -j${BUILD_JOBS} ${MBUILD_TARGET}
|
||||
EOF
|
||||
upload_caches: ccache
|
||||
@@ -111,6 +113,7 @@ task:
|
||||
# tap test that exercises both a frontend binary and the backend.
|
||||
test_minimal_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
ulimit -c unlimited
|
||||
meson test $MTEST_ARGS --suite setup
|
||||
meson test $MTEST_ARGS --num-processes ${TEST_JOBS} \
|
||||
@@ -173,6 +176,7 @@ task:
|
||||
# already takes longer than other platforms except for windows.
|
||||
configure_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
meson setup \
|
||||
--buildtype=debug \
|
||||
-Dcassert=true -Dinjection_points=true \
|
||||
@@ -186,6 +190,7 @@ task:
|
||||
|
||||
test_world_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
ulimit -c unlimited
|
||||
meson test $MTEST_ARGS --num-processes ${TEST_JOBS}
|
||||
EOF
|
||||
@@ -210,6 +215,7 @@ task:
|
||||
# during upload, as it doesn't expect artifacts to change size
|
||||
stop_running_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
build/tmp_install/usr/local/pgsql/bin/pg_ctl -D build/runningcheck stop || true
|
||||
EOF
|
||||
<<: *on_failure_meson
|
||||
@@ -330,6 +336,7 @@ task:
|
||||
# that.
|
||||
configure_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
./configure \
|
||||
--enable-cassert --enable-injection-points --enable-debug \
|
||||
--enable-tap-tests --enable-nls \
|
||||
@@ -344,6 +351,7 @@ task:
|
||||
|
||||
test_world_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
ulimit -c unlimited # default is 0
|
||||
make -s ${CHECK} ${CHECKFLAGS} -j${TEST_JOBS}
|
||||
EOF
|
||||
@@ -359,6 +367,7 @@ task:
|
||||
|
||||
configure_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
meson setup \
|
||||
--buildtype=debug \
|
||||
-Dcassert=true -Dinjection_points=true \
|
||||
@@ -371,6 +380,7 @@ task:
|
||||
# locally.
|
||||
configure_32_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
export CC='ccache gcc -m32'
|
||||
meson setup \
|
||||
--buildtype=debug \
|
||||
@@ -390,6 +400,7 @@ task:
|
||||
|
||||
test_world_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
ulimit -c unlimited
|
||||
meson test $MTEST_ARGS --num-processes ${TEST_JOBS}
|
||||
EOF
|
||||
@@ -402,6 +413,7 @@ task:
|
||||
# from C, prevent that with PYTHONCOERCECLOCALE.
|
||||
test_world_32_script: |
|
||||
su postgres <<-EOF
|
||||
set -e
|
||||
ulimit -c unlimited
|
||||
PYTHONCOERCECLOCALE=0 LANG=C meson test $MTEST_ARGS -C build-32 --num-processes ${TEST_JOBS}
|
||||
EOF
|
||||
|
||||
Reference in New Issue
Block a user