database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Fix incorrect error message reported for non-existent users

Browse Source 
Previously, lookups of non-existent user names could return "Success";
it will now return "User does not exist" by resetting errno.  This also
centralizes the user name lookup code in libpgport.

Report and analysis by Nicolas Marchildon;  patch by me
This commit is contained in:
Bruce Momjian
2013-12-18 12:16:16 -05:00
parent 11ac4c73cb
commit 613c6d26bd
19 changed files with 129 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
contrib/pg_upgrade/util.c
View File

@ -203,32 +203,25 @@ quote_identifier(const char *s)
/*
* get_user_info()
* (copied from initdb.c) find the current user
*/
int
get_user_info(char **user_name)
{
int user_id;
char *errstr;
#ifndef WIN32
struct passwd *pw = getpwuid(geteuid());
user_id = geteuid();
#else /* the windows code */
struct passwd_win32
{
int pw_uid;
char pw_name[128];
} pass_win32;
struct passwd_win32 *pw = &pass_win32;
DWORD pwname_size = sizeof(pass_win32.pw_name) - 1;
GetUserName(pw->pw_name, &pwname_size);
#else
user_id = 1;
#endif
*user_name = pg_strdup(pw->pw_name);
*user_name = get_user_name(&errstr);
if (!*user_name)
pg_fatal("%s\n", errstr);
/* make a copy */
*user_name = pg_strdup(*user_name);
return user_id;
}