diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 26628f3e6d3..3a062a145ca 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -2723,7 +2723,7 @@ include_dir 'conf.d' Note that changing wal_level to minimal makes any base backups taken before unavailable for archive recovery and standby server, which may - lead to database loss. + lead to data loss. In logical level, the same information is logged as @@ -3098,7 +3098,7 @@ include_dir 'conf.d' When this parameter is on, the PostgreSQL - server compresses a full page image written to WAL when + server compresses full page images written to WAL when is on or during a base backup. A compressed page image will be decompressed during WAL replay. The default value is off. @@ -4137,7 +4137,7 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"' # Windows On the subscriber side, specifies how many replication origins (see ) can be tracked simultaneously, effectively limiting how many logical replication subscriptions can - be created on the server. Setting it a lower value than the current + be created on the server. Setting it to a lower value than the current number of tracked replication origins (reflected in pg_replication_origin_status, not pg_replication_origin) @@ -7732,12 +7732,12 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv; The extension also requires a query identifier to be computed. Note that an external module can alternatively be used if the in-core query identifier computation - specification isn't acceptable. In this case, in-core computation + method is not acceptable. In this case, in-core computation must be disabled. The default is off. - To ensure that a only one query identifier is calculated and + To ensure that only one query identifier is calculated and displayed, extensions that calculate query identifiers should throw an error if a query identifier has already been computed. diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 0606b6a9aa4..67d802b02c2 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -3560,7 +3560,7 @@ repeat('Pg', 4) PgPgPgPg text - Evaluate escaped Unicode characters in argument. Unicode characters + Evaluate escaped Unicode characters in the argument. Unicode characters can be specified as \XXXX (4 hexadecimal digits), \+XXXXXX (6 @@ -24926,12 +24926,12 @@ SELECT collation for ('foo' COLLATE "de_DE"); boolean - Requests to log the memory contexts whose backend process has - the specified process ID. These memory contexts will be logged at + Requests to log the memory contexts of the backend with the + specified process ID. These memory contexts will be logged at LOG message level. They will appear in the server log based on the log configuration set (See for more information), - but will not be sent to the client whatever the setting of + but will not be sent to the client regardless of . Only superusers can request to log the memory contexts. @@ -25037,7 +25037,7 @@ SELECT collation for ('foo' COLLATE "de_DE"); pg_log_backend_memory_contexts can be used - to log the memory contexts of the backend process. For example, + to log the memory contexts of a backend process. For example: postgres=# SELECT pg_log_backend_memory_contexts(pg_backend_pid()); pg_log_backend_memory_contexts @@ -25061,8 +25061,8 @@ LOG: level: 1; TransactionAbortContext: 32768 total in 1 blocks; 32504 free (0 LOG: level: 1; ErrorContext: 8192 total in 1 blocks; 7928 free (3 chunks); 264 used LOG: Grand total: 1651920 bytes in 201 blocks; 622360 free (88 chunks); 1029560 used - For more than 100 child contexts under the same parent one, - 100 child contexts and a summary of the remaining ones will be logged. + If there are more than 100 child contexts under the same parent, the first + 100 child contexts are logged, along with a summary of the remaining contexts. Note that frequent calls to this function could incur significant overhead, because it may generate a large number of log messages. @@ -25576,7 +25576,7 @@ postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup()); Returns recovery pause state. The return values are not paused if pause is not requested, pause requested if pause is requested but recovery is - not yet paused and, paused if the recovery is + not yet paused, and paused if the recovery is actually paused. diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index e95d446dacb..73789526518 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -490,9 +490,9 @@ any changes that happened during the initial data copy using standard logical replication. During this synchronization phase, the changes are applied and committed in the same order as they happened on the - publisher. Once the synchronization is done, the control of the + publisher. Once synchronization is done, control of the replication of the table is given back to the main apply process where - the replication continues as normal. + replication continues as normal. @@ -602,10 +602,9 @@ - The subscriber also requires the max_replication_slots - be set to configure how many replication origins can be tracked. In this - case it should be set to at least the number of subscriptions that will be - added to the subscriber, plus some reserve for table synchronization. + max_replication_slots must also be set on the subscriber. + It should be set to at least the number of subscriptions that will be added + to the subscriber, plus some reserve for table synchronization. max_logical_replication_workers must be set to at least the number of subscriptions, again plus some reserve for the table synchronization. Additionally the max_worker_processes diff --git a/doc/src/sgml/maintenance.sgml b/doc/src/sgml/maintenance.sgml index 3bbae6dd917..4adb34a21b1 100644 --- a/doc/src/sgml/maintenance.sgml +++ b/doc/src/sgml/maintenance.sgml @@ -185,7 +185,7 @@ never issue VACUUM FULL. In this approach, the idea is not to keep tables at their minimum size, but to maintain steady-state usage of disk space: each table occupies space equivalent to its - minimum size plus however much space gets used up between vacuumings. + minimum size plus however much space gets used up between vacuum runs. Although VACUUM FULL can be used to shrink a table back to its minimum size and return the disk space to the operating system, there is not much point in this if the table will just grow again in the diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index f637fe04152..8287587f614 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -5890,7 +5890,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid, When creating an index on a partitioned table, this column is set to - the number of partitions on which the index has been completed. + the number of partitions on which the index has been created. This field is 0 during a REINDEX. diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml index e0d3f246e9a..89ff58338e5 100644 --- a/doc/src/sgml/perform.sgml +++ b/doc/src/sgml/perform.sgml @@ -1747,7 +1747,7 @@ SELECT * FROM x, y, a, b, c WHERE something AND somethingelse; to zero. But note that changing these settings requires a server restart, and makes any base backups taken before unavailable for archive - recovery and standby server, which may lead to database loss. + recovery and standby server, which may lead to data loss. @@ -1899,7 +1899,7 @@ SELECT * FROM x, y, a, b, c WHERE something AND somethingelse; much faster. The following are configuration changes you can make to improve performance in such cases. Except as noted below, durability is still guaranteed in case of a crash of the database software; - only abrupt operating system stoppage creates a risk of data loss + only an abrupt operating system crash creates a risk of data loss or corruption when these settings are used. diff --git a/doc/src/sgml/pgstatstatements.sgml b/doc/src/sgml/pgstatstatements.sgml index 5ad4f0aed2a..e235504e9a9 100644 --- a/doc/src/sgml/pgstatstatements.sgml +++ b/doc/src/sgml/pgstatstatements.sgml @@ -406,7 +406,7 @@ The following details about constant replacement and - queryid only applies when queryid only apply when is enabled. If you use an external module instead to compute queryid, you should refer to its documentation for details. diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml index fd349569369..5320accf6f4 100644 --- a/doc/src/sgml/postgres-fdw.sgml +++ b/doc/src/sgml/postgres-fdw.sgml @@ -551,8 +551,9 @@ OPTIONS (ADD password_required 'false'); Connection Management Options - By default all the open connections that postgres_fdw - established to the foreign servers are kept in local session for re-use. + By default, all connections that postgres_fdw + establishes to foreign servers are kept open in the local session + for re-use. @@ -562,11 +563,11 @@ OPTIONS (ADD password_required 'false'); This option controls whether postgres_fdw keeps - the connections to the foreign server open so that the subsequent + the connections to the foreign server open so that subsequent queries can re-use them. It can only be specified for a foreign server. The default is on. If set to off, all connections to this foreign server will be discarded at the end of - transaction. + each transaction. diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml index 44e50620fd1..d7fffddbce3 100644 --- a/doc/src/sgml/ref/create_table.sgml +++ b/doc/src/sgml/ref/create_table.sgml @@ -1520,7 +1520,7 @@ WITH ( MODULUS numeric_literal, REM - + autovacuum_vacuum_scale_factor, toast.autovacuum_vacuum_scale_factor (floating point) autovacuum_vacuum_scale_factor @@ -1610,7 +1610,7 @@ WITH ( MODULUS numeric_literal, REM - + autovacuum_vacuum_cost_limit, toast.autovacuum_vacuum_cost_limit (integer) autovacuum_vacuum_cost_limit diff --git a/doc/src/sgml/ref/createuser.sgml b/doc/src/sgml/ref/createuser.sgml index 4d60dc2cda1..17579e50afb 100644 --- a/doc/src/sgml/ref/createuser.sgml +++ b/doc/src/sgml/ref/createuser.sgml @@ -44,7 +44,7 @@ PostgreSQL documentation If you wish to create a new superuser, you must connect as a superuser, not merely with CREATEROLE privilege. Being a superuser implies the ability to bypass all access permission - checks within the database, so superuserdom should not be granted lightly. + checks within the database, so superuser access should not be granted lightly. diff --git a/doc/src/sgml/ref/declare.sgml b/doc/src/sgml/ref/declare.sgml index 8a2b8cc8929..aa3d1d1fa16 100644 --- a/doc/src/sgml/ref/declare.sgml +++ b/doc/src/sgml/ref/declare.sgml @@ -335,7 +335,7 @@ DECLARE liahona CURSOR FOR SELECT * FROM films; According to the SQL standard, changes made to insensitive cursors by UPDATE ... WHERE CURRENT OF and DELETE - ... WHERE CURRENT OF statements are visibible in that same + ... WHERE CURRENT OF statements are visible in that same cursor. PostgreSQL treats these statements like all other data changing statements in that they are not visible in insensitive cursors. diff --git a/doc/src/sgml/ref/pg_amcheck.sgml b/doc/src/sgml/ref/pg_amcheck.sgml index fcc96b430a6..d01e26faa81 100644 --- a/doc/src/sgml/ref/pg_amcheck.sgml +++ b/doc/src/sgml/ref/pg_amcheck.sgml @@ -460,7 +460,7 @@ PostgreSQL documentation - If "all-frozen" is given, table corruption checks + If all-frozen is given, table corruption checks will skip over pages in all tables that are marked as all frozen. diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml index ddb70433625..a3cfd3b5575 100644 --- a/doc/src/sgml/ref/psql-ref.sgml +++ b/doc/src/sgml/ref/psql-ref.sgml @@ -1927,9 +1927,10 @@ testdb=> - The column of the kind of extended stats (e.g. Ndistinct) shows its status. - NULL means that it doesn't exists. "defined" means that it was requested - when creating the statistics. + The status of each kind of extended statistics is shown in a column + named after its statistic kind (e.g. Ndistinct). + "defined" means that it was requested when creating the statistics, + and NULL means it wasn't requested. You can use pg_stats_ext if you'd like to know whether ANALYZE was run and statistics are available to the planner. diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml index 0f13c43095e..24cf567ee2e 100644 --- a/doc/src/sgml/wal.sgml +++ b/doc/src/sgml/wal.sgml @@ -797,7 +797,7 @@ fsync, or fsync_writethrough, the write operation moves WAL buffers to kernel cache and issue_xlog_fsync syncs them to disk. Regardless - of the setting of track_wal_io_timing, the numbers + of the setting of track_wal_io_timing, the number of times XLogWrite writes and issue_xlog_fsync syncs WAL data to disk are also counted as wal_write and wal_sync diff --git a/src/backend/catalog/heap.c b/src/backend/catalog/heap.c index 9f6303266f9..ba03e8aa8f3 100644 --- a/src/backend/catalog/heap.c +++ b/src/backend/catalog/heap.c @@ -1119,6 +1119,7 @@ AddNewRelationType(const char *typeName, * reltypeid: OID to assign to rel's rowtype, or InvalidOid to select one * reloftypeid: if a typed table, OID of underlying type; else InvalidOid * ownerid: OID of new rel's owner + * accessmtd: OID of new rel's access method * tupdesc: tuple descriptor (source of column definitions) * cooked_constraints: list of precooked check constraints and defaults * relkind: relkind for new rel diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c index 5bdaceefd5d..182a1330332 100644 --- a/src/backend/commands/analyze.c +++ b/src/backend/commands/analyze.c @@ -617,7 +617,7 @@ do_analyze_rel(Relation onerel, VacuumParams *params, * * We assume that VACUUM hasn't set pg_class.reltuples already, even * during a VACUUM ANALYZE. Although VACUUM often updates pg_class, - * exceptions exists. A "VACUUM (ANALYZE, INDEX_CLEANUP OFF)" command + * exceptions exist. A "VACUUM (ANALYZE, INDEX_CLEANUP OFF)" command * will never update pg_class entries for index relations. It's also * possible that an individual index's pg_class entry won't be updated * during VACUUM if the index AM returns NULL from its amvacuumcleanup() diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index 096a06f7b3b..6487a9e3fcb 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -1422,7 +1422,7 @@ finish_heap_swap(Oid OIDOldHeap, Oid OIDNewHeap, PROGRESS_CLUSTER_PHASE_FINAL_CLEANUP); /* - * If the relation being rebuild is pg_class, swap_relation_files() + * If the relation being rebuilt is pg_class, swap_relation_files() * couldn't update pg_class's own pg_class entry (check comments in * swap_relation_files()), thus relfrozenxid was not updated. That's * annoying because a potential reason for doing a VACUUM FULL is a diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c index 20e7d57d41f..40a54ad0bd7 100644 --- a/src/backend/commands/copyfrom.c +++ b/src/backend/commands/copyfrom.c @@ -410,7 +410,7 @@ CopyMultiInsertBufferCleanup(CopyMultiInsertInfo *miinfo, * Once flushed we also trim the tracked buffers list down to size by removing * the buffers created earliest first. * - * Callers should pass 'curr_rri' is the ResultRelInfo that's currently being + * Callers should pass 'curr_rri' as the ResultRelInfo that's currently being * used. When cleaning up old buffers we'll never remove the one for * 'curr_rri'. */ diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c index 463d44a68a4..4674168ff80 100644 --- a/src/backend/statistics/extended_stats.c +++ b/src/backend/statistics/extended_stats.c @@ -254,7 +254,7 @@ BuildRelationExtStatistics(Relation onerel, double totalrows, * that would require additional columns. * * See statext_compute_stattarget for details about how we compute statistics - * target for a statistics objects (from the object target, attribute targets + * target for a statistics object (from the object target, attribute targets * and default statistics target). */ int diff --git a/src/backend/utils/adt/jsonfuncs.c b/src/backend/utils/adt/jsonfuncs.c index 9961d27df47..09fcff67299 100644 --- a/src/backend/utils/adt/jsonfuncs.c +++ b/src/backend/utils/adt/jsonfuncs.c @@ -1651,7 +1651,7 @@ push_null_elements(JsonbParseState **ps, int num) * this path. E.g. the path [a][0][b] with the new value 1 will produce the * structure {a: [{b: 1}]}. * - * Called is responsible to make sure such path does not exist yet. + * Caller is responsible to make sure such path does not exist yet. */ static void push_path(JsonbParseState **st, int level, Datum *path_elems, @@ -4887,7 +4887,7 @@ IteratorConcat(JsonbIterator **it1, JsonbIterator **it2, * than just one last element, this flag will instruct to create the whole * chain of corresponding objects and insert the value. * - * JB_PATH_CONSISTENT_POSITION for an array indicates that the called wants to + * JB_PATH_CONSISTENT_POSITION for an array indicates that the caller wants to * keep values with fixed indices. Indices for existing elements could be * changed (shifted forward) in case if the array is prepended with a new value * and a negative index out of the range, so this behavior will be prevented diff --git a/src/bin/pg_amcheck/t/004_verify_heapam.pl b/src/bin/pg_amcheck/t/004_verify_heapam.pl index 36607596b1b..2171d236a7a 100644 --- a/src/bin/pg_amcheck/t/004_verify_heapam.pl +++ b/src/bin/pg_amcheck/t/004_verify_heapam.pl @@ -175,7 +175,7 @@ sub write_tuple seek($fh, $offset, 0) or BAIL_OUT("seek failed: $!"); defined(syswrite($fh, $buffer, HEAPTUPLE_PACK_LENGTH)) - or BAIL_OUT("syswrite failed: $!");; + or BAIL_OUT("syswrite failed: $!"); return; } diff --git a/src/include/lib/sort_template.h b/src/include/lib/sort_template.h index 771c789ced0..24d6d0006cf 100644 --- a/src/include/lib/sort_template.h +++ b/src/include/lib/sort_template.h @@ -241,7 +241,7 @@ ST_SCOPE void ST_SORT(ST_ELEMENT_TYPE *first, size_t n /* * Find the median of three values. Currently, performance seems to be best - * if the the comparator is inlined here, but the med3 function is not inlined + * if the comparator is inlined here, but the med3 function is not inlined * in the qsort function. */ static pg_noinline ST_ELEMENT_TYPE * diff --git a/src/include/utils/guc.h b/src/include/utils/guc.h index 1892c7927b4..7894940741e 100644 --- a/src/include/utils/guc.h +++ b/src/include/utils/guc.h @@ -90,13 +90,12 @@ typedef enum * dividing line between "interactive" and "non-interactive" sources for * error reporting purposes. * - * PGC_S_TEST is used when testing values to be used later ("doit" will always - * be false, so this never gets stored as the actual source of any value). - * For example, ALTER DATABASE/ROLE tests proposed per-database or per-user - * defaults this way, and CREATE FUNCTION tests proposed function SET clauses - * this way. This is an interactive case, but it needs its own source value - * because some assign hooks need to make different validity checks in this - * case. In particular, references to nonexistent database objects generally + * PGC_S_TEST is used when testing values to be used later. For example, + * ALTER DATABASE/ROLE tests proposed per-database or per-user defaults this + * way, and CREATE FUNCTION tests proposed function SET clauses this way. + * This is an interactive case, but it needs its own source value because + * some assign hooks need to make different validity checks in this case. + * In particular, references to nonexistent database objects generally * shouldn't throw hard errors in this case, at most NOTICEs, since the * objects might exist by the time the setting is used for real. *