mirror of
https://github.com/postgres/postgres.git
synced 2025-08-17 01:02:17 +03:00
Improve code around the recently added rm_identify rmgr callback.
There are four weaknesses in728f152e07f998d2cb4fe5f24ec8da2c3bda98f2: * append_init() in heapdesc.c was ugly and required that rm_identify return values are only valid till the next call. Instead just add a couple more switch() cases for the INIT_PAGE cases. Now the returned value will always be valid. * a couple rm_identify() callbacks missed masking xl_info with ~XLR_INFO_MASK. * pg_xlogdump didn't map a NULL rm_identify to UNKNOWN or a similar string. * append_init() was called when id=NULL - which should never actually happen. But it's better to be careful.
This commit is contained in:
@@ -69,7 +69,7 @@ gist_identify(uint8 info)
|
||||
{
|
||||
const char *id = NULL;
|
||||
|
||||
switch (info)
|
||||
switch (info & ~XLR_INFO_MASK)
|
||||
{
|
||||
case XLOG_GIST_PAGE_UPDATE:
|
||||
id = "PAGE_UPDATE";
|
||||
|
Reference in New Issue
Block a user