mirror of
https://github.com/postgres/postgres.git
synced 2025-08-30 06:01:21 +03:00
Back-patch fcff8a5751
as a bug fix.
When there is both a serialization failure and a unique violation, throw the former rather than the latter. When initially pushed, this was viewed as a feature to assist application framework developers, so that they could more accurately determine when to retry a failed transaction, but a test case presented by Ian Jackson has shown that this patch can prevent serialization anomalies in some cases where a unique violation is caught within a subtransaction, the work of that subtransaction is discarded, and no error is thrown. That makes this a bug fix, so it is being back-patched to all supported branches where it is not already present (i.e., 9.2 to 9.5). Discussion: https://postgr.es/m/1481307991-16971-1-git-send-email-ian.jackson@eu.citrix.com Discussion: https://postgr.es/m/22607.56276.807567.924144@mariner.uk.xensource.com
This commit is contained in:
@@ -369,6 +369,14 @@ _bt_check_unique(Relation rel, IndexTuple itup, Relation heapRel,
|
||||
break;
|
||||
}
|
||||
|
||||
/*
|
||||
* Check for a conflict-in as we would if we were going to
|
||||
* write to this page. We aren't actually going to write,
|
||||
* but we want a chance to report SSI conflicts that would
|
||||
* otherwise be masked by this unique constraint violation.
|
||||
*/
|
||||
CheckForSerializableConflictIn(rel, NULL, buf);
|
||||
|
||||
/*
|
||||
* This is a definite conflict. Break the tuple down into
|
||||
* datums and report the error. But first, make sure we
|
||||
|
Reference in New Issue
Block a user