mirror of
https://github.com/postgres/postgres.git
synced 2025-05-01 01:04:50 +03:00
Fix comments about bgworker registration before MaxBackends initialization
Since 6bc8ef0b, InitializeMaxBackends() has used max_worker_processes instead of adapting MaxBackends to the number of background workers registered by modules loaded in shared_preload_libraries (at this time, bgworkers were only static, but gained dynamic capabilities as a matter of supporting parallel queries meaning that a control cap was necessary). Some comments referred to the past registration logic, making them confusing and incorrect, so fix these. Some of the out-of-core modules that could be loaded in this path sometimes like to manipulate dynamically some of the resource-related GUCs for their own needs, this commit adds a note about that. Author: Nathan Bossart Discussion: https://postgr.es/m/20220127181815.GA551692@nathanxps13
This commit is contained in:
parent
bf42fcace5
commit
5ecd0183fb
@ -1014,10 +1014,8 @@ PostmasterMain(int argc, char *argv[])
|
|||||||
LocalProcessControlFile(false);
|
LocalProcessControlFile(false);
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Register the apply launcher. Since it registers a background worker,
|
* Register the apply launcher. It's probably a good idea to call this
|
||||||
* it needs to be called before InitializeMaxBackends(), and it's probably
|
* before any modules had a chance to take the background worker slots.
|
||||||
* a good idea to call it before any modules had chance to take the
|
|
||||||
* background worker slots.
|
|
||||||
*/
|
*/
|
||||||
ApplyLauncherRegister();
|
ApplyLauncherRegister();
|
||||||
|
|
||||||
@ -1038,8 +1036,8 @@ PostmasterMain(int argc, char *argv[])
|
|||||||
#endif
|
#endif
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Now that loadable modules have had their chance to register background
|
* Now that loadable modules have had their chance to alter any GUCs,
|
||||||
* workers, calculate MaxBackends.
|
* calculate MaxBackends.
|
||||||
*/
|
*/
|
||||||
InitializeMaxBackends();
|
InitializeMaxBackends();
|
||||||
|
|
||||||
|
@ -483,9 +483,8 @@ pg_split_opts(char **argv, int *argcp, const char *optstr)
|
|||||||
/*
|
/*
|
||||||
* Initialize MaxBackends value from config options.
|
* Initialize MaxBackends value from config options.
|
||||||
*
|
*
|
||||||
* This must be called after modules have had the chance to register background
|
* This must be called after modules have had the chance to alter GUCs in
|
||||||
* workers in shared_preload_libraries, and before shared memory size is
|
* shared_preload_libraries and before shared memory size is determined.
|
||||||
* determined.
|
|
||||||
*
|
*
|
||||||
* Note that in EXEC_BACKEND environment, the value is passed down from
|
* Note that in EXEC_BACKEND environment, the value is passed down from
|
||||||
* postmaster to subprocesses via BackendParameters in SubPostmasterMain; only
|
* postmaster to subprocesses via BackendParameters in SubPostmasterMain; only
|
||||||
|
Loading…
x
Reference in New Issue
Block a user